Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation / Architecture #842

Closed
kennylavender opened this issue Dec 3, 2018 · 1 comment · Fixed by #843
Closed

Documentation / Architecture #842

kennylavender opened this issue Dec 3, 2018 · 1 comment · Fixed by #843
Assignees
@kennylavender
Labels
released

Comments

@kennylavender
Copy link
Contributor

kennylavender commented Dec 3, 2018 •
edited by lautarodragan
Loading

Part of #239

Original comment: #836 (review)

related: #836

Document the current architecture before merging #836

Create a src/README.md with a little bit of detail of the current overall architecture.
Once we merge src/README.md to master, merge master to this branch and modify it in this PR, so it's super clear that this PR is introducing an architectural change.
The src/README.md to be created in another branch doesn't need to be complete or fancy, since that may hold this PR off for longer than desired. I think we can get away with it being mostly placeholders, and focusing mostly on the section that will later be changed by this PR.
@kennylavender kennylavender self-assigned this Dec 3, 2018
@kennylavender kennylavender added this to the PML1 milestone Dec 3, 2018
@kennylavender kennylavender mentioned this issue Dec 3, 2018
Merged
kennylavender added a commit that referenced this issue Dec 3, 2018
@kennylavender
Merge branch 'master' into kenny-#842
1070d81
lautarodragan added a commit that referenced this issue Dec 4, 2018
@lautarodragan
Merge branch 'kenny-#842' into lautarodragan-patch-1
fb13706
@poet-ci
Copy link

poet-ci commented Dec 5, 2018

🎉 This issue has been resolved in version 2.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennylavender kennylavender

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document some architecture in src/README poetapp/node
3 participants
@lautarodragan @kennylavender @poet-ci