From 215a756566732fec61ca0a8a4962c128948658dc Mon Sep 17 00:00:00 2001 From: Ayla Pearson Date: Tue, 26 Nov 2024 17:15:06 -0800 Subject: [PATCH 1/4] remove as no vignettes in pkg and fixes note in R CMD check --- DESCRIPTION | 1 - 1 file changed, 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index 10c51d1..b5aa48b 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -44,5 +44,4 @@ LazyData: true RoxygenNote: 7.3.1 RdMacros: lifecycle Language: en-US -VignetteBuilder: knitr Roxygen: list(markdown = TRUE) From 9ea32c0d94dfa335e07c34ebae4901fb26d6744c Mon Sep 17 00:00:00 2001 From: Ayla Pearson Date: Tue, 26 Nov 2024 17:15:56 -0800 Subject: [PATCH 2/4] update to newest roxygen note --- DESCRIPTION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index b5aa48b..356308b 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -41,7 +41,7 @@ URL: https://github.com/bcgov/shinywqg BugReports: https://github.com/bcgov/shinywqg/issues Encoding: UTF-8 LazyData: true -RoxygenNote: 7.3.1 +RoxygenNote: 7.3.2 RdMacros: lifecycle Language: en-US Roxygen: list(markdown = TRUE) From c17d66c22c72ce5e8428eb436438ac04ad3933c4 Mon Sep 17 00:00:00 2001 From: Ayla Pearson Date: Tue, 26 Nov 2024 17:29:49 -0800 Subject: [PATCH 3/4] update version and add news file --- DESCRIPTION | 2 +- NEWS.md | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 NEWS.md diff --git a/DESCRIPTION b/DESCRIPTION index 356308b..6ef04c3 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: shinywqg Title: Water Quality Guideline Shiny App -Version: 0.1.0 +Version: 0.1.0.9000 Authors@R: c( person("Sebastian", "Dalgarno", , "seb@poissonconsulting.ca", "aut", comment = c(ORCID = "0000-0002-3658-4517")), person("Pearson", "Ayla", , "ayla@poissonconsulting.ca", c("aut", "cre"), comment = c(ORCID = "0000-0001-7388-1222")), diff --git a/NEWS.md b/NEWS.md new file mode 100644 index 0000000..9c12ecc --- /dev/null +++ b/NEWS.md @@ -0,0 +1,5 @@ + + +# shinywqg 0.1.0.9000 (2024-11-26) + +- Package maintenance. From cc58dde8c091776f7b698d6020c5160f5f02404c Mon Sep 17 00:00:00 2001 From: Ayla Pearson Date: Thu, 28 Nov 2024 17:18:27 -0800 Subject: [PATCH 4/4] adding Testing.md --- .Rbuildignore | 1 + TESTING.md | 40 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+) create mode 100644 TESTING.md diff --git a/.Rbuildignore b/.Rbuildignore index 5925acc..c46e871 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -21,3 +21,4 @@ ^joe-notes-0211\.rtf$ ^COMPLIANCE\.yaml$ ^\.github$ +^TESTING\.md$ \ No newline at end of file diff --git a/TESTING.md b/TESTING.md new file mode 100644 index 0000000..9bf9211 --- /dev/null +++ b/TESTING.md @@ -0,0 +1,40 @@ +# Steps for manual testing of the app + + This document is to guide developers on how to manually test the app. + Steps should be followed in order and be done in a single session from start to finish. + +1. Open app: https://bcgov-env.shinyapps.io/bc_wqg/ +2. Click on User Guide tab + a. Confirm formatting looks valid +3. Click on About tab + a. Confirm formatting looks valid + b. Check URLs are not broken +4. Confirm footer links are valid +5. Click on WQG tab + a. Click on download button + b. Select 1,1-Dicholoroethylene + i. Select Drinking water + 1) Confirm results appears and are formatted correctly + 2) Check links are active and correct + ii. Tick water off and on + 1) Results should disappear if nothing ticked and then re-appear when ticked again + c. Select Copper by typing copper + i. Select Aquatic Life - Marine, Aquatic Life - Freshwater and Wildlife + ii. Confirm reports appear and are formatted correctly + 1) Check links are active and correct + iii. Change Hardness value to 130 + 1) No change + iv. Change pH to 8 + 1) Should cause a guideline to change + v. Change Dissolved Organic Carbon to 2 + 1) Should cause guidelines changes + vi. Change Significant Figures to 2 + 1) Should drop decimal points (ie only whole numbers left) + vii. Change significant figures to 5 + 1) Should increase values to multiple decimal points + viii. Tick off water media + 1) Parameter options should disappear + d. Select pH + i. Add all values + ii. Select a pH value of 1 + 1) Results should appear \ No newline at end of file