From 02f497da2b73e8b66b7c3deccf4bd2e36c3bb773 Mon Sep 17 00:00:00 2001 From: dharjeezy Date: Wed, 3 Jul 2024 16:21:21 +0100 Subject: [PATCH 1/2] Explicit default for testnet HostConfiguration (#368) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit close #362 - [x] Does not require a CHANGELOG entry --------- Co-authored-by: Bastian Köcher Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com> --- chain-spec-generator/src/relay_chain_specs.rs | 27 +++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/chain-spec-generator/src/relay_chain_specs.rs b/chain-spec-generator/src/relay_chain_specs.rs index e8c2fa3c8a..5ee20389d8 100644 --- a/chain-spec-generator/src/relay_chain_specs.rs +++ b/chain-spec-generator/src/relay_chain_specs.rs @@ -21,7 +21,11 @@ use beefy_primitives::ecdsa_crypto::AuthorityId as BeefyId; use grandpa::AuthorityId as GrandpaId; use kusama_runtime_constants::currency::UNITS as KSM; use pallet_staking::Forcing; -use polkadot_primitives::{AccountId, AccountPublic, AssignmentId, ValidatorId}; +use polkadot_primitives::{ + vstaging::{ApprovalVotingParams, NodeFeatures}, + AccountId, AccountPublic, AssignmentId, AsyncBackingParams, ValidatorId, + ON_DEMAND_DEFAULT_QUEUE_MAX_SIZE, +}; use polkadot_runtime_constants::currency::UNITS as DOT; use runtime_parachains::configuration::HostConfiguration; use sc_chain_spec::{ChainSpec, ChainType, NoExtension}; @@ -76,7 +80,26 @@ fn default_parachains_host_configuration() -> HostConfiguration Date: Wed, 3 Jul 2024 23:37:58 +0200 Subject: [PATCH 2/2] updated review-bot dependencies to latest (`2.5.0`) (#373) This commit updates get-fellows-action to v1.1.4 where `papi` was updated to latest (`0.9.0`) which contains a fix for polkadot-api/polkadot-api#327. This will accelerate the process of the triggering of review-bot. Review-bot has also been updated to latest. It has the pull request number being injected, so it will always fetch the latest status when it runs. With the fix provided in #369 this should make the whole process work as intended. - [x] Does not require a CHANGELOG entry --------- Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com> --- .github/workflows/auto-merge.yml | 4 ++-- .github/workflows/review-bot.yml | 6 +++--- .github/workflows/review-trigger.yml | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/auto-merge.yml b/.github/workflows/auto-merge.yml index ef1cfb7b88..e533fe048c 100644 --- a/.github/workflows/auto-merge.yml +++ b/.github/workflows/auto-merge.yml @@ -14,11 +14,11 @@ jobs: if: ${{ github.event.issue.pull_request && startsWith(github.event.comment.body, '/merge') }} steps: - name: Get the GitHub handle of the fellows - uses: paritytech/get-fellows-action@v1.1.3 + uses: paritytech/get-fellows-action@v1.1.4 id: fellows - name: Generate a token id: merge_token - uses: actions/create-github-app-token@v1.8.1 + uses: actions/create-github-app-token@v1 with: app-id: ${{ secrets.MERGE_APP_ID }} private-key: ${{ secrets.MERGE_APP_KEY }} diff --git a/.github/workflows/review-bot.yml b/.github/workflows/review-bot.yml index 40306bad8c..b04b6159f2 100644 --- a/.github/workflows/review-bot.yml +++ b/.github/workflows/review-bot.yml @@ -16,17 +16,17 @@ jobs: steps: - name: Extract content of artifact id: number - uses: Bullrich/extract-text-from-artifact@v1.0.0 + uses: Bullrich/extract-text-from-artifact@v1.0.1 with: artifact-name: pr_number - name: Generate token id: team_token - uses: actions/create-github-app-token@v1.9.3 + uses: actions/create-github-app-token@v1 with: app-id: ${{ secrets.REVIEW_APP_ID }} private-key: ${{ secrets.REVIEW_APP_KEY }} - name: "Evaluates PR reviews and assigns reviewers" - uses: paritytech/review-bot@v2.4.1 + uses: paritytech/review-bot@v2.5.0 with: repo-token: ${{ secrets.GITHUB_TOKEN }} team-token: ${{ steps.team_token.outputs.token }} diff --git a/.github/workflows/review-trigger.yml b/.github/workflows/review-trigger.yml index f1b5281939..783980467b 100644 --- a/.github/workflows/review-trigger.yml +++ b/.github/workflows/review-trigger.yml @@ -28,7 +28,7 @@ jobs: env: GH_TOKEN: ${{ github.token }} - name: Get the GitHub handle of the fellows - uses: paritytech/get-fellows-action@v1.1.3 + uses: paritytech/get-fellows-action@v1.1.4 id: fellows # Require new reviews when the author is pushing and he is not a fellow - name: Fail when author pushes new code