Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit default for testnet HostConfiguration #362

Closed
ggwpez opened this issue Jun 26, 2024 · 3 comments · Fixed by #368
Closed

Explicit default for testnet HostConfiguration #362

ggwpez opened this issue Jun 26, 2024 · 3 comments · Fixed by #368

Comments

@ggwpez
Copy link
Member

ggwpez commented Jun 26, 2024

A ..Default::default() here is hiding newly added fields.
Maybe someone should take a look if these values are sane and add explicit default so that it fails in the future instead of using 0.
@ggwpez ggwpez mentioned this issue Jun 26, 2024
Merged
4 tasks
@dharjeezy
Copy link
Contributor

For this, are you saying we specify each property and provide them with their default one by one?

@ggwpez
Copy link
Member Author

ggwpez commented Jun 29, 2024

Yea, but i dont know what values are good defaults.

This was referenced Jun 29, 2024
Closed
Merged
fellowship-merge-bot bot added a commit that referenced this issue Jul 3, 2024
@dharjeezy @bkchr @fellowship-merge-bot
Explicit default for testnet HostConfiguration (#368)
02f497d 
close #362 

- [x] Does not require a CHANGELOG entry

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>
@ggwpez
Copy link
Member Author

ggwpez commented Jul 4, 2024

Done in #368

@ggwpez ggwpez closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ggwpez @dharjeezy