Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy settings ignored #17

Open
demonti opened this issue Apr 27, 2020 · 0 comments
Open

Proxy settings ignored #17

demonti opened this issue Apr 27, 2020 · 0 comments

Comments

@demonti
Copy link

demonti commented Apr 27, 2020

The library you are using sets the "NO_PROXY" proxy by default, causing any default settings, including the http(s).proxyHost and proxyPort system properties, to be ignored. I was able to fix by adding the following statement to the ACMECommand constructor:

session.setProxy(ProxySelector.getDefault().
  select(URI.create(this.parameters.getAcmeServerUrl())).get(0));

This should also work for environments that do not need proxies, if I understand the Java documentation correctly (the select returns always at least one entry). But I haven't tested it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant