Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop 'support-cors' usersync YAML config #4160

Open
bretg opened this issue Jan 17, 2025 · 0 comments
Open

Drop 'support-cors' usersync YAML config #4160

bretg opened this issue Jan 17, 2025 · 0 comments

Comments

@bretg
Copy link
Contributor

bretg commented Jan 17, 2025

Since before even my time in PBS, the YAML files have supported a 'support-cors' field in usersync. Of 230+ bid adapters, only 2 set this to true.

I don't see any code in PBS that looks at this field.

My suspicion is that it's an information flag indicating that the bidder's sync endpoint sets some specific CORS header like Access-Control-Allow-Credentials and/or Access-Control-Allow-Origin. However, That's not documented anywhere and I'm not aware of the use case that drive this ancient config setting.

So I'm proposing that we either:

  • drop support-cors from the usersync YAML entirely
  • OR document what use case it supports and when bidders should declare support-cors:true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

1 participant