Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DART SASS 2.0.0 support - @Import @use - v1.80.0 sass #239

Open
Jorelia opened this issue Nov 27, 2024 · 2 comments
Open

DART SASS 2.0.0 support - @Import @use - v1.80.0 sass #239

Jorelia opened this issue Nov 27, 2024 · 2 comments

Comments

@Jorelia
Copy link

Jorelia commented Nov 27, 2024

We move a project that uses SASS and we starting to have some deprecated warning in our CSS/SASS file while running unit tests. Actually using "sass": "^1.81.0". Then it seems a breaking change is going to happen.

Deprecation Warning: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.

More info: https://sass-lang.com/d/legacy-js-api

On the Net we caught a discussion about a v4 but the thread is relatively old... on Sep 13, 2023.

So we would like to know if a move from your side will be done, to update the project for SASS v2 (actually "sass": "^1.58.3") or we need to abandon this artefact because it won't be maintain anymore.

Also related to @import vs @use

Thank you very much for your answer.

Best regards,

@Jorelia Jorelia changed the title DART SASS 2.0.0 support DART SASS 2.0.0 support - @Import @use - v1.80.0 sass Nov 27, 2024
@scholtz
Copy link

scholtz commented Dec 29, 2024

I am getting the same issue after fresh install of primevue and primeflex. Is primeflex deprecated and everyone should use tailwind now on?

image

@Jorelia
Copy link
Author

Jorelia commented Dec 30, 2024

I think you can use tailwind as it seems there is something here https://tailwind.primevue.org/ - https://github.com/primefaces/primevue-tailwind and the project seems active too.

In our case, we decide to not go with it at the first step. We use the unstyled mode, hybrid: https://primevue.org/theming/unstyled/ then we are writing our own style.

We try to go with the semantic CSS approach and if we use tailwind, then we will use @apply https://tailwindcss.com/docs/functions-and-directives.

The choice depends more on the knowledge of the dev., how they are confortable with and the current state of the project (and of course the budget). In our case, we decided to refactor our CSS/SCSS to make a deep clean as it was pretty difficult to maintain, slow in rendering and have other integration challenges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants