From cda5fc7229ef294f2671804b05a8ab0edd99587b Mon Sep 17 00:00:00 2001 From: Tyler Jones Date: Mon, 13 Nov 2023 19:55:27 +0000 Subject: [PATCH] Clean up further --- .changeset/lucky-gifts-rule.md | 2 +- docs/content/SplitPageLayout.mdx | 4 ++-- src/PageLayout/PageLayout.tsx | 2 -- src/SplitPageLayout/SplitPageLayout.docs.json | 15 --------------- src/SplitPageLayout/SplitPageLayout.stories.tsx | 1 - src/SplitPageLayout/SplitPageLayout.tsx | 1 - 6 files changed, 3 insertions(+), 22 deletions(-) diff --git a/.changeset/lucky-gifts-rule.md b/.changeset/lucky-gifts-rule.md index c23de0149d5..35852362cac 100644 --- a/.changeset/lucky-gifts-rule.md +++ b/.changeset/lucky-gifts-rule.md @@ -2,4 +2,4 @@ '@primer/react': minor --- -Added `PageLayout.PaneHeading` slot to `PageLayout` which utilizes `` as its base. +Adjusts position of children within `PageLayout.Pane` to live above adjustable resize form. diff --git a/docs/content/SplitPageLayout.mdx b/docs/content/SplitPageLayout.mdx index 430926300ee..d9b500ae643 100644 --- a/docs/content/SplitPageLayout.mdx +++ b/docs/content/SplitPageLayout.mdx @@ -237,13 +237,13 @@ If you need a more flexible layout component, consider using the [PageLayout](/P ``` -### With pane heading +### With heading ```jsx live drafts - Pane Heading + Pane Heading diff --git a/src/PageLayout/PageLayout.tsx b/src/PageLayout/PageLayout.tsx index 9b582d62124..a739265a82d 100644 --- a/src/PageLayout/PageLayout.tsx +++ b/src/PageLayout/PageLayout.tsx @@ -517,8 +517,6 @@ export type PageLayoutPaneProps = { resizable?: boolean widthStorageKey?: string padding?: keyof typeof SPACING_MAP - heading?: string - headingLevel?: 'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6' divider?: 'none' | 'line' | ResponsiveValue<'none' | 'line', 'none' | 'line' | 'filled'> /** * @deprecated Use the `divider` prop with a responsive value instead. diff --git a/src/SplitPageLayout/SplitPageLayout.docs.json b/src/SplitPageLayout/SplitPageLayout.docs.json index 1399d255208..e6bfeda2865 100644 --- a/src/SplitPageLayout/SplitPageLayout.docs.json +++ b/src/SplitPageLayout/SplitPageLayout.docs.json @@ -154,21 +154,6 @@ "type": "SystemStyleObject" } ] - }, - { - "name": "SplitPageLayout.PaneHeading", - "props": [ - { - "name": "as", - "type": "'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6'", - "required": true, - "defaultValue": "" - }, - { - "name": "sx", - "type": "SystemStyleObject" - } - ] } ] } diff --git a/src/SplitPageLayout/SplitPageLayout.stories.tsx b/src/SplitPageLayout/SplitPageLayout.stories.tsx index 2413105f2ae..39f09809d15 100644 --- a/src/SplitPageLayout/SplitPageLayout.stories.tsx +++ b/src/SplitPageLayout/SplitPageLayout.stories.tsx @@ -340,7 +340,6 @@ const Template: Story = args => ( {args['Render pane?'] ? (