diff --git a/.changeset/fifty-rockets-joke.md b/.changeset/fifty-rockets-joke.md new file mode 100644 index 00000000000..41fe6d3c7d0 --- /dev/null +++ b/.changeset/fifty-rockets-joke.md @@ -0,0 +1,5 @@ +--- +"@primer/react": minor +--- + +fix(PageHeader): add role prop and aria-label in top-level element diff --git a/packages/react/src/Hidden/Hidden.examples.stories.tsx b/packages/react/src/Hidden/Hidden.examples.stories.tsx index ea47ba0f91b..238fa0f77cc 100644 --- a/packages/react/src/Hidden/Hidden.examples.stories.tsx +++ b/packages/react/src/Hidden/Hidden.examples.stories.tsx @@ -22,7 +22,7 @@ const setViewportParamToNarrow = { } export const Webhooks = () => ( - + Repository settings @@ -51,7 +51,7 @@ WebhooksOnNarrowViewport.parameters = setViewportParamToNarrow export const PullRequestPage = () => ( - + Pull requests diff --git a/packages/react/src/PageHeader/PageHeader.dev.stories.tsx b/packages/react/src/PageHeader/PageHeader.dev.stories.tsx index 4dd501791ca..ce7cabd967a 100644 --- a/packages/react/src/PageHeader/PageHeader.dev.stories.tsx +++ b/packages/react/src/PageHeader/PageHeader.dev.stories.tsx @@ -18,7 +18,11 @@ export default meta export const LargeVariantWithMultilineTitle = () => ( - + @@ -46,7 +50,7 @@ export const LargeVariantWithMultilineTitle = () => ( export const ArrayTypeFontSizeOnTitle = () => ( - + ( export const ThemeBaseFontSizeOnTitle = () => ( - + ( export const StringTypeFontSizeOnTitle = () => ( - + ( - + Webhooks @@ -78,7 +78,10 @@ WebhooksOnNarrowViewport.parameters = setViewportParamToNarrow export const PullRequestPage = () => ( - + PageHeader component initial layout explorations extra long pull request title @@ -146,7 +149,7 @@ PullRequestPageOnNarrowViewport.parameters = setViewportParamToNarrow export const FilesPage = () => ( - + / diff --git a/packages/react/src/PageHeader/PageHeader.features.stories.tsx b/packages/react/src/PageHeader/PageHeader.features.stories.tsx index 30966076a04..5624ea08c79 100644 --- a/packages/react/src/PageHeader/PageHeader.features.stories.tsx +++ b/packages/react/src/PageHeader/PageHeader.features.stories.tsx @@ -31,7 +31,7 @@ const meta: Meta = { export const HasTitleOnly = () => ( - + Title @@ -41,7 +41,7 @@ export const HasTitleOnly = () => ( export const HasLargeTitle = () => ( - + Title @@ -51,7 +51,7 @@ export const HasLargeTitle = () => ( export const WithLeadingAndTrailingVisuals = () => ( - + @@ -67,7 +67,7 @@ export const WithLeadingAndTrailingVisuals = () => ( export const WithLeadingVisualHiddenOnRegularViewport = () => ( - +