Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate cli package into demo #12

Closed
3 tasks
0xmad opened this issue Jan 23, 2024 · 5 comments
Closed
3 tasks

Integrate cli package into demo #12

0xmad opened this issue Jan 23, 2024 · 5 comments

Comments

@0xmad
Copy link
Collaborator

0xmad commented Jan 23, 2024

Description

As a user I'd like to use maci-cli package for my frontend app.

Acceptance criteria

  • Support user signups (signup w/ MACI contract)
  • Support user votes (publishMessage w/ Poll contract)
  • Support displaying all the information related to poll (ethers)
@samajammin
Copy link
Member

Love it. A few thoughts on this (at least for v1 of a demo) - I think some of these can be nice-to-haves vs. hard requirements:

Support user keypair change

IMO this isn't something we'd need to build support for in a v1

Implement coordinator dashboard

Same here. Coordinator could manage everything purely from the CLI to start. I think top priority should be accounting for user flow to vote in the UI

@samajammin
Copy link
Member

@0xmad potentially dumb question - when you say:

I'd like to use maci-cli package for my frontend app.

Are you saying being able to run CLI commands from within that repo? Or leveraging CLI commands as some API on the frontend? When you mention implementing dashboards, it makes me suspect the latter

@0xmad
Copy link
Collaborator Author

0xmad commented Jan 26, 2024

@samajammin in case if we can drop support for coordinator and user keypair change, we don't need dashboards at all.
Regarding cli: this package can be install as a dependency and we can use it without terminal module with demo app.

@kittybest
Copy link
Contributor

Implement coordinator dashboard

Same here. Coordinator could manage everything purely from the CLI to start. I think top priority should be accounting for user flow to vote in the UI

I also think it's a nice to have, but since it's actually only for the coordinator (which is the owner of our deployed demo contracts a.k.a us) so it doesn't need to be gorgeous, we only need to create a page and link cli function to it.

@kittybest kittybest mentioned this issue Jan 29, 2024
6 tasks
@samajammin samajammin transferred this issue from privacy-scaling-explorations/maci Jan 29, 2024
samajammin pushed a commit that referenced this issue Jan 29, 2024
@samajammin
Copy link
Member

This issue seems redundant with others...

Description

As a user I'd like to use maci-cli package for my frontend app.

Acceptance criteria

  • Support user signups (signup w/ MACI contract)
  • Support user votes (publishMessage w/ Poll contract)
  • Support displaying all the information related to poll (ethers)

@0xmad @kittybest @ctrlc03 LMK if I'm missing something but seems this is covered in:

Closing this out but feel free to re-open & explain what's different here.

@github-project-automation github-project-automation bot moved this from Backlog to Done in MACI Jan 30, 2024
@ctrlc03 ctrlc03 removed their assignment Jan 30, 2024
@ctrlc03 ctrlc03 removed this from MACI Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants