Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update immutable contract variables to SNAKE_CASE #1012

Closed
samajammin opened this issue Jan 13, 2024 · 3 comments
Closed

Update immutable contract variables to SNAKE_CASE #1012

samajammin opened this issue Jan 13, 2024 · 3 comments
Labels
chore Chore tasks

Comments

@samajammin
Copy link
Member

samajammin commented Jan 13, 2024

Motivation

Small linting update

Details

lint:sol warns that immutable variables should use SNAKE_CASE:
Image 2024-01-13 at 12 50 08

Relates to updates in #1008

@samajammin samajammin added the chore Chore tasks label Jan 13, 2024
@ctrlc03
Copy link
Collaborator

ctrlc03 commented Jan 23, 2024

@samajammin perhaps we can close once we merge this #1083? -

"immutable-vars-naming": ["warn", { "immutablesAsConstants": false }]
disables this rule which (at least imo) makes the code nicer than a bunch of capital snake case vars.

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Feb 22, 2024

@samajammin what you think of the above suggestion?

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Mar 14, 2024

I'll close this for now, but feel free to re-open if you believe that muting the warning is a not a good enough resolution for this

@ctrlc03 ctrlc03 closed this as completed Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore tasks
Projects
None yet
Development

No branches or pull requests

2 participants