Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Innacurate Number of Valid State Indices Check #1236

Closed
ctrlc03 opened this issue Feb 23, 2024 · 0 comments
Closed

Innacurate Number of Valid State Indices Check #1236

ctrlc03 opened this issue Feb 23, 2024 · 0 comments
Assignees
Labels
bug Something isn't working Security

Comments

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Feb 23, 2024

The state tree should contain numSignUps valid leaves. However, the circuit counts the index=numSignUps as a valid index where the state leaf indices are 0 based. So the max valid index should be numSignUps - 1. Since the state leaf at numSignUps is a 0 leaf, the user or coordinator can’t manipulate the voting process with this issue. Therefore this issue is minor.

Fixed by #1200

@ctrlc03 ctrlc03 added this to MACI Feb 23, 2024
@ctrlc03 ctrlc03 converted this from a draft issue Feb 23, 2024
@ctrlc03 ctrlc03 self-assigned this Feb 23, 2024
@ctrlc03 ctrlc03 added Security bug Something isn't working labels Feb 23, 2024
@ctrlc03 ctrlc03 closed this as completed Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Security
Projects
Status: Done
Development

No branches or pull requests

1 participant