Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot often fails #488

Open
gpaar opened this issue Jan 10, 2025 · 3 comments
Open

Screenshot often fails #488

gpaar opened this issue Jan 10, 2025 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@gpaar
Copy link
Collaborator

gpaar commented Jan 10, 2025

In unpredictable cases the screenshot function fails which later causes PRo3D to crash. Apparently a target view area is not available.
I tried to open the complained https address in Edge which showed the same window as the PRo3D display except for the actual scene.
(thereafter, no activities were possible anymore on the application windows).
It would be good to find the reason (i.e. to avoid it) and find a mitigation if possible. The documented case happened even directly after computer restart.

In version 4.27.0-prerelease4 it does not seem to work with any scene

Screenshot-Fails
Screenshot-fails.txt
![DIGL208-GP-JR](https://github.com/use
S1294.zip
r-attachments/assets/aa94710a-eda2-4adc-a439-1af40bb050f2)
DIGL208-GP-JR

@gpaar gpaar added the bug Something isn't working label Jan 10, 2025
@haraldsteinlechner
Copy link
Collaborator

Thanks for the detailled report. Here are two problems

  1. i updated the screenshot code to countermeasure the "sometime fails" problem and messed it up in the latest pre-release versions. i fixed it in 4.27.0-prerelease5, which is just about being built on github and will arrive there in some minutes
  2. i assume you copied the screenshot url to the browser, right? (looks like http://localhost:53437/rendering/screenshot/n11650?w=500&h=500&samples=4&fmt=png&background=[0.396078,0.168627,0.168627,1.000000]). i cannot reproduce this one, but from looking at the log file (thanks for providing), it seems like a configuration of the framebuffer is broken. I'm quite sure this is data independent, but i will try it with your data (right now i can't so i leave this one open)

@haraldsteinlechner
Copy link
Collaborator

haraldsteinlechner commented Jan 10, 2025

I just noticed your download link does not work.
image
But here is the new version: https://github.com/pro3d-space/PRo3D/releases/tag/4.27.0-prerelease5
PS.: i'm quite sure the screenshots worked despite the error message being printed (they run asynchronously and as long as pro3d ran long enough to generate the screenshot it is on disk anyways). so i think the screenshots you did are on your disk already.

@gpaar
Copy link
Collaborator Author

gpaar commented Jan 10, 2025

Thx, First screenshot worked, second not, neither was the second stored, opposed to earlier faults with Prerelease4 where you correctly assumed that even upon failure the screenshot/s were/was stored. Not an urgent issue for now, however. I an see all relevant screenshots up there, there seems to be a truncated link which is not relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants