Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline mode deprecation #87

Open
ithielnor opened this issue Nov 3, 2017 · 0 comments
Open

Inline mode deprecation #87

ithielnor opened this issue Nov 3, 2017 · 0 comments
Milestone

Comments

@ithielnor
Copy link
Collaborator

ithielnor commented Nov 3, 2017

In order to move away from the current inline mode which is not conducive to mobile, the idea is presented to move the inline filtering into the filter summary instead:

  • Option on GriddlyFilter for IsInline which forces the filter to always show in the summary regardless of value
    • IsInline filters would not be removable from the summary.
    • IsInline filters would be editable in the summary (discussion required of how. Ideas for popover or inline form elements...)
  • Non IsInline filters would be removable as currently in 2.0 alpha 5
    • would be nice to be editable in the summary too (though perhaps that's a bridge too far).
  • GriddlyHtmlFilters could never be IsInline

Discuss.

@ithielnor ithielnor added this to the 2.0 milestone Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant