Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User management APIs should use a consistent field name for the partner identifier #2

Open
kochhar opened this issue Jul 24, 2017 · 0 comments
Assignees

Comments

@kochhar
Copy link
Contributor

kochhar commented Jul 24, 2017

Presently the user and org management APIs use different field names for the same data in different API calls. These should be made uniform.

Eg:

  • in createUser the partner identifier is under the field name provider
  • in createOrg the partner identifier is under the field name source
  • in the JWT auth tokens the partner identifier is under the field name iss

While we cannot change the field name in the JWT token because the spec requires it to be in the iss field, we should adjust the user and org APIs to use a consistent field name.

If provider is not an overloaded term in sunbird, it could be a good standard to adopt for all kinds of partners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants