From de8e8abb01d49a7aa0c86a85243cd8f37e5e621c Mon Sep 17 00:00:00 2001
From: ArthurCarli <43670852+ArthurCarli@users.noreply.github.com>
Date: Sun, 1 Sep 2024 00:56:27 +0200
Subject: [PATCH] fix: Various build errors related to APP_VERSION_IDENTIFIER &
 IS_QA_BUILD

---
 AutoFill/Info.plist                                  |  8 ++++----
 .../Sources/Core/Utilities/BundleExtensions.swift    |  6 +++---
 Share/Info.plist                                     |  8 ++++----
 iOS/App/Info.plist                                   | 12 ++++++------
 4 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/AutoFill/Info.plist b/AutoFill/Info.plist
index d48da04fc..a5737af18 100644
--- a/AutoFill/Info.plist
+++ b/AutoFill/Info.plist
@@ -2,10 +2,10 @@
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
-	<key>APP_VERSION_IDENTIFIER =
-	<string>$(APP_VERSION_IDENTIFIER =
-	<key>IS_QA_BUILD =
-	<string>$(IS_QA_BUILD =
+	<key>APP_VERSION_IDENTIFIER</key>
+	<string>$(APP_VERSION_IDENTIFIER)</string>
+	<key>IS_QA_BUILD</key>
+	<string>$(IS_QA_BUILD)</string>
 	<key>MODULE</key>
 	<string>AUTOFILL_EXTENSION</string>
 	<key>NSExtension</key>
diff --git a/LocalPackages/Core/Sources/Core/Utilities/BundleExtensions.swift b/LocalPackages/Core/Sources/Core/Utilities/BundleExtensions.swift
index ebe819490..abb765ebc 100644
--- a/LocalPackages/Core/Sources/Core/Utilities/BundleExtensions.swift
+++ b/LocalPackages/Core/Sources/Core/Utilities/BundleExtensions.swift
@@ -23,10 +23,10 @@ import Foundation
 public extension Bundle {
     var versionNumber: String { string(forKey: "CFBundleShortVersionString") ?? "0.0.0" }
     var buildNumber: String { string(forKey: "CFBundleVersion") ?? "0" }
-    var versionIdentifier: String? { string(forKey: "APP_VERSION_IDENTIFIER =
+    var versionIdentifier: String? { string(forKey: "APP_VERSION_IDENTIFIER") }
     var gitCommitHash: String? { string(forKey: "GIT_COMMIT_HASH") }
-    var isQaBuild: Bool { bool(forKey: "IS_QA_BUILD =
-    var isBetaBuild: Bool { bool(forKey: "IS_BETA_BUILD =
+    var isQaBuild: Bool { bool(forKey: "IS_QA_BUILD") }
+    var isBetaBuild: Bool { bool(forKey: "IS_BETA_BUILD")}
 
     /// Get the full name of the current version e.g "1.0.0-dev" or "1.2.0"
     var fullAppVersionName: String {
diff --git a/Share/Info.plist b/Share/Info.plist
index efc64e815..17e4a3f67 100644
--- a/Share/Info.plist
+++ b/Share/Info.plist
@@ -2,10 +2,10 @@
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
-	<key>APP_VERSION_IDENTIFIER =
-	<string>$(APP_VERSION_IDENTIFIER =
-	<key>IS_QA_BUILD =
-	<string>$(IS_QA_BUILD =
+	<key>APP_VERSION_IDENTIFIER</key>
+	<string>$(APP_VERSION_IDENTIFIER)</string>
+	<key>IS_QA_BUILD</key>
+	<string>$(IS_QA_BUILD)</string>
 	<key>MODULE</key>
 	<string>SHARE_EXTENSION</string>
 	<key>NSExtension</key>
diff --git a/iOS/App/Info.plist b/iOS/App/Info.plist
index aa108ff29..75cbdec21 100644
--- a/iOS/App/Info.plist
+++ b/iOS/App/Info.plist
@@ -2,8 +2,8 @@
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
-	<key>APP_VERSION_IDENTIFIER =
-	<string>$(APP_VERSION_IDENTIFIER =
+	<key>APP_VERSION_IDENTIFIER</key>
+	<string>$(APP_VERSION_IDENTIFIER)</string>
 	<key>CFBundleURLTypes</key>
 	<array>
 		<dict>
@@ -19,10 +19,10 @@
 	</array>
 	<key>GIT_COMMIT_HASH</key>
 	<string></string>
-	<key>IS_BETA_BUILD =
-	<string>$(IS_BETA_BUILD =
-	<key>IS_QA_BUILD =
-	<string>$(IS_QA_BUILD =
+	<key>IS_BETA_BUILD</key>
+	<string>$(IS_BETA_BUILD)</string>
+	<key>IS_QA_BUILD</key>
+	<string>$(IS_QA_BUILD)</string>
 	<key>ITSAppUsesNonExemptEncryption</key>
 	<false/>
 	<key>ITSEncryptionExportComplianceCode</key>