From 2696384a343bf9876490aaf2f82d4aaa259ae9b0 Mon Sep 17 00:00:00 2001
From: Farhad Safarov <farhad.safarov@gmail.com>
Date: Wed, 5 Jun 2024 17:29:08 +0300
Subject: [PATCH] remove obsolete feature & fix test

---
 .../Core/Authorization/Voter/Voter.stubphp    | 42 -------------------
 .../acceptance/ContainerXml.feature           |  1 +
 tests/acceptance/acceptance/Voter.feature     | 40 ------------------
 3 files changed, 1 insertion(+), 82 deletions(-)
 delete mode 100644 src/Stubs/common/Component/Security/Core/Authorization/Voter/Voter.stubphp
 delete mode 100644 tests/acceptance/acceptance/Voter.feature

diff --git a/src/Stubs/common/Component/Security/Core/Authorization/Voter/Voter.stubphp b/src/Stubs/common/Component/Security/Core/Authorization/Voter/Voter.stubphp
deleted file mode 100644
index 57d88416..00000000
--- a/src/Stubs/common/Component/Security/Core/Authorization/Voter/Voter.stubphp
+++ /dev/null
@@ -1,42 +0,0 @@
-<?php
-
-namespace Symfony\Component\Security\Core\Authorization\Voter;
-
-use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
-
-abstract class Voter implements VoterInterface
-{
-    /**
-     * Returns the vote for the given parameters.
-     *
-     * This method must return one of the following constants:
-     * ACCESS_GRANTED, ACCESS_DENIED, or ACCESS_ABSTAIN.
-     *
-     * @param mixed $subject    The subject to secure
-     * @param array $attributes An array of attributes associated with the method being invoked
-     *
-     * @return int either ACCESS_GRANTED, ACCESS_ABSTAIN, or ACCESS_DENIED
-     */
-    public function vote(TokenInterface $token, $subject, array $attributes) {}
-
-    /**
-     * Determines if the attribute and subject are supported by this voter.
-     *
-     * @param string $attribute An attribute
-     * @param mixed  $subject   The subject to secure, e.g. an object the user wants to access or any other PHP type
-     *
-     * @return bool True if the attribute and subject are supported, false otherwise
-     */
-    abstract protected function supports(string $attribute, $subject);
-
-    /**
-     * Perform a single access check operation on a given attribute, subject and token.
-     * It is safe to assume that $attribute and $subject already passed the "supports()" method check.
-     *
-     * @psalm-suppress MoreSpecificImplementedParamType
-     * @param mixed $subject
-     *
-     * @return bool
-     */
-    abstract protected function voteOnAttribute(string $attribute, $subject, TokenInterface $token);
-}
diff --git a/tests/acceptance/acceptance/ContainerXml.feature b/tests/acceptance/acceptance/ContainerXml.feature
index 6cb8b9cc..8021a8e1 100644
--- a/tests/acceptance/acceptance/ContainerXml.feature
+++ b/tests/acceptance/acceptance/ContainerXml.feature
@@ -12,6 +12,7 @@ Feature: Container XML config
       <?php
 
       use \Symfony\Component\DependencyInjection\ContainerInterface;
+      use \Symfony\Component\HttpKernel\HttpKernelInterface;
       """
 
   Scenario: Asserting psalm recognizes return type of service got via 'ContainerInterface::get() using service ID'
diff --git a/tests/acceptance/acceptance/Voter.feature b/tests/acceptance/acceptance/Voter.feature
deleted file mode 100644
index 2dca842d..00000000
--- a/tests/acceptance/acceptance/Voter.feature
+++ /dev/null
@@ -1,40 +0,0 @@
-@symfony-common
-Feature: Voter abstract class
-
-  Background:
-    Given I have Symfony plugin enabled
-    And I have the following code preamble
-      """
-      <?php
-
-      use Symfony\Component\Security\Core\Authorization\Voter\Voter;
-      use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
-
-      class VoterSubject {}
-      """
-
-  Scenario: Assert MoreSpecificImplementedParamType is not raised on voteOnAttribute
-    Given I have the following code
-      """
-      class SomeVoter extends Voter
-      {
-          protected function supports(string $attribute, $subject): bool
-          {
-              return $subject instanceof VoterSubject;
-          }
-
-          /**
-           * @param VoterSubject $subject
-           */
-          protected function voteOnAttribute(string $attribute, $subject, TokenInterface $token): bool
-          {
-              /** @psalm-trace $subject */
-              return true;
-          }
-      }
-      """
-    When I run Psalm
-    Then I see these errors
-      | Type  | Message                |
-      | Trace | $subject: VoterSubject |
-    And I see no other errors