Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Need improvements for handling of whitelists and blacklists upon import/refresh #7

Open
pschneider1968 opened this issue Dec 22, 2022 · 2 comments · Fixed by #8
Assignees
Labels
enhancement New feature or request

Comments

@pschneider1968
Copy link
Owner

pschneider1968 commented Dec 22, 2022

Currently upon refresh, we nuke (=completely replace) all whitelists and blacklists from our files. This might not be what the user wants, because he or she might have setup whitelists and/or blacklists of his/her own.

So we need to implement a better way to deal with these lists. Probably some logic like the ADD/MERGE/DELETE/FULL mode for the list_of_blocklists.txt file.

However this is complicated by the fact that for white-/blacklists, stored in the domains table in the Gravity DB, we have no master table like we have for adlists->gravity so there is no possibilty yet to have white-/blacklists grouped together and identify them as a collection of entries.

So probably this needs to be addressed as an enhancement request to upstream Pi-Hole developers.

If so, I will link to relevant communication with upstream here.

@pschneider1968 pschneider1968 self-assigned this Dec 22, 2022
@pschneider1968 pschneider1968 added the enhancement New feature or request label Dec 22, 2022
@pschneider1968 pschneider1968 pinned this issue Dec 22, 2022
@pschneider1968
Copy link
Owner Author

pschneider1968 commented Dec 22, 2022

Probably, this could be handled by making use of the Groups feature, although this was meant for a completely different purpose, i.e.for mapping clients to rules/rule sets.

@pschneider1968
Copy link
Owner Author

Still open...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant