Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMRCon_IsCmdFromRCon has a lot of precondition #13

Open
DosMike opened this issue Jun 17, 2023 · 0 comments
Open

SMRCon_IsCmdFromRCon has a lot of precondition #13

DosMike opened this issue Jun 17, 2023 · 0 comments
Labels

Comments

@DosMike
Copy link

DosMike commented Jun 17, 2023

SMRCon_IsCmdFromRCon() only returns true if all checks and preconditions in WriteDataRequest are fulfilled, which includes that at least one plugin registeres for SMRCon_OnCommand.

If I just want to use SMRCon to block commands from being run though/outside rcon, without additional auth checks or modifications, this is suboptimal. I dont know if g_bInRConCommand should be true thoughout the whole hook, but i think it should be at least true for the case without SMRCon_OnCommand callbacks. That way I dont have to add an empty SMRCon_OnCommand.

Thank you for reading 😄

@psychonic psychonic added the bug label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants