Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jquery v1.11.1 #1

Open
lttr09 opened this issue Aug 18, 2014 · 6 comments
Open

jquery v1.11.1 #1

lttr09 opened this issue Aug 18, 2014 · 6 comments

Comments

@lttr09
Copy link

lttr09 commented Aug 18, 2014

Hi, awesome plugin. I have noticed that version 2 doesn't work with the lastest jquery v1.11.1
Sorry for bad english.

@pushpendraas400
Copy link
Owner

Hi:
Thanks for reporting this issue. We will update the repository with v1.11.1 support soon.

@dilana
Copy link

dilana commented Aug 25, 2014

Hi there,

i just changed one line of code, and the plugin now its working with the latest jQuery, i didn't tested all its futures, but its a start.

Line 242:
from

var P = B.find("li:nth-child('" + Q + "')");

to

var P = B.find("li:nth-child(" + Q + ")");

@lttr09
Copy link
Author

lttr09 commented Sep 16, 2014

Hi guys, any eta on a fix to this issue? tested dilana work around but some of the features is not working.
thanks.

@pushpendraas400
Copy link
Owner

Hi:

We are trying to fix the issue.

@darylphuah
Copy link
Contributor

I faced the same issue, and fixed it by changing the nth-child calls to use .eq() instead.

I've made a pull request with the changes, you may review and merge it if all's good.

@pushpendraas400
Copy link
Owner

Hi Daryl:
Main issue here is CSS3 animation(zoom effect) is not properly working when used with jquery 1.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants