From 80ae99e2dd3ddf0c5e854a8d5f32945150c2874f Mon Sep 17 00:00:00 2001
From: Nevio Di Gennaro <digennaro@puzzle.ch>
Date: Tue, 26 Nov 2024 15:39:38 +0100
Subject: [PATCH] fix bug that you couldnt edit objectives anymore

---
 .run/OkrApplication-Dev.run.xml               |  2 +-
 .../src/app/services/objective.service.ts     | 19 +++++++++++++--
 .../objective-form.component.html             | 10 +++-----
 .../objective-form.component.ts               | 24 +++++++++++--------
 4 files changed, 35 insertions(+), 20 deletions(-)

diff --git a/.run/OkrApplication-Dev.run.xml b/.run/OkrApplication-Dev.run.xml
index 67aa73cb9b..cc81cd897d 100644
--- a/.run/OkrApplication-Dev.run.xml
+++ b/.run/OkrApplication-Dev.run.xml
@@ -1,7 +1,7 @@
 <component name="ProjectRunConfigurationManager">
   <configuration default="false" name="OkrApplication-Dev" type="SpringBootApplicationConfigurationType" factoryName="Spring Boot">
     <option name="ACTIVE_PROFILES" value="dev" />
-    <option name="ALTERNATIVE_JRE_PATH" value="$USER_HOME$/.sdkman/candidates/java/current" />
+    <option name="ALTERNATIVE_JRE_PATH" value="openjdk-21" />
     <option name="ALTERNATIVE_JRE_PATH_ENABLED" value="true" />
     <module name="backend" />
     <option name="SPRING_BOOT_MAIN_CLASS" value="ch.puzzle.okr.OkrApplication" />
diff --git a/frontend/src/app/services/objective.service.ts b/frontend/src/app/services/objective.service.ts
index 62d9b51165..a7ada8396e 100644
--- a/frontend/src/app/services/objective.service.ts
+++ b/frontend/src/app/services/objective.service.ts
@@ -4,6 +4,9 @@ import { Objective } from '../shared/types/model/Objective';
 import { Observable } from 'rxjs';
 import { KeyResult } from '../shared/types/model/KeyResult';
 import { KeyResultDTO } from '../shared/types/DTOs/KeyResultDTO';
+import { User } from '../shared/types/model/User';
+import { CheckIn } from '../shared/types/model/CheckIn';
+import { Action } from '../shared/types/model/Action';
 
 @Injectable({
   providedIn: 'root',
@@ -34,8 +37,20 @@ export class ObjectiveService {
   duplicateObjective(
     objectiveId: number,
     duplicateObjectiveDto: {
-      objective: Objective;
-      keyResults: KeyResult[];
+      keyResults: {
+        owner: User;
+        modifiedOn: Date | null | undefined;
+        keyResultType: string | undefined;
+        description: string;
+        actionList: Action[] | null;
+        id: undefined;
+        lastCheckIn: CheckIn | null | undefined;
+        title: string;
+        version: number;
+        createdOn: Date | null | undefined;
+        objective: Objective;
+      }[];
+      objective: any;
     },
   ): Observable<Objective> {
     return this.httpClient.post<Objective>(`/api/v2/objectives/${objectiveId}`, duplicateObjectiveDto);
diff --git a/frontend/src/app/shared/dialog/objective-dialog/objective-form.component.html b/frontend/src/app/shared/dialog/objective-dialog/objective-form.component.html
index 1523f46932..1651deeb90 100644
--- a/frontend/src/app/shared/dialog/objective-dialog/objective-form.component.html
+++ b/frontend/src/app/shared/dialog/objective-dialog/objective-form.component.html
@@ -65,16 +65,12 @@
             </mat-checkbox>
           </div>
         </div>
-        <div class="col align-self-end w-100">
+        <div *ngIf="data.action === 'duplicate'" class="col align-self-end w-100">
           <div class="okr-form-row okr-form-label-input-container w-100">
-            <label class="okr-form-label okr-form-col" for="keyresults">Keyresults übernehmen</label>
+            <label class="okr-form-label okr-form-col">Keyresults übernehmen</label>
             <div class="okr-form-input pe-5 w-100">
               <ng-container *ngIf="keyResults$ | async as keyResults" formArrayName="keyResults">
-                <mat-checkbox
-                  *ngFor="let keyResult of keyResults; let i = index"
-                  [formControlName]="i"
-                  id="keyresults-{{ i }}"
-                >
+                <mat-checkbox *ngFor="let keyResult of keyResults; let i = index" [formControlName]="i">
                   {{ keyResult.title }}
                 </mat-checkbox>
               </ng-container>
diff --git a/frontend/src/app/shared/dialog/objective-dialog/objective-form.component.ts b/frontend/src/app/shared/dialog/objective-dialog/objective-form.component.ts
index 1896c551ef..d6dc2dd1e6 100644
--- a/frontend/src/app/shared/dialog/objective-dialog/objective-form.component.ts
+++ b/frontend/src/app/shared/dialog/objective-dialog/objective-form.component.ts
@@ -79,12 +79,7 @@ export class ObjectiveFormComponent implements OnInit, OnDestroy {
       state: state,
     } as unknown as Objective;
 
-    const submitFunction = this.getSubmitFunction(this.data.objective.objectiveId!, {
-      objective: objectiveDTO,
-      keyResults: this.keyResults
-        .filter((keyResult, index) => value.keyResults[index])
-        .map((result) => ({ ...result, id: undefined })),
-    });
+    const submitFunction = this.getSubmitFunction(this.data.objective.objectiveId!, objectiveDTO);
     submitFunction.subscribe((savedObjective: Objective) => {
       this.closeDialog(savedObjective, false, value.createKeyResults!);
     });
@@ -138,12 +133,21 @@ export class ObjectiveFormComponent implements OnInit, OnDestroy {
     if (this.data.action == 'duplicate') {
       objectiveDTO.id = null;
       objectiveDTO.state = 'DRAFT' as State;
-      return this.objectiveService.duplicateObjective(id, objectiveDTO);
+      return this.objectiveService.duplicateObjective(id, {
+        objective: objectiveDTO,
+        keyResults: this.keyResults
+          .filter((keyResult, index) =>
+            this.objectiveForm.value.keyResults ? this.objectiveForm.value.keyResults[index] : false,
+          )
+          .map((result) => ({ ...result, id: undefined })),
+      });
     } else {
       if (this.data.action == 'releaseBacklog') objectiveDTO.state = 'ONGOING' as State;
-      return id
-        ? this.objectiveService.updateObjective(objectiveDTO)
-        : this.objectiveService.createObjective(objectiveDTO);
+      if (this.data.objective.objectiveId) {
+        objectiveDTO.id = id;
+        return this.objectiveService.updateObjective(objectiveDTO);
+      }
+      return this.objectiveService.createObjective(objectiveDTO);
     }
   }