Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro's are not working #669

Open
bithir opened this issue Aug 7, 2024 · 0 comments
Open

Macro's are not working #669

bithir opened this issue Aug 7, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@bithir
Copy link
Collaborator

bithir commented Aug 7, 2024

Quite a few macros need updating - this is related to #526 - macros stored in compendiums is missed every time major Foundry VTT changes, as they are not identified when we search our codebase for what needs to change.

In addition to this, it is exacerbated by being in multiple languages (even though the CRB importers are depending on the language of the book) having their own implementation.

My recommendation is that we move these in to macros.js, perhaps even as is without i18n, to ensure that they are captured when we identify impact for Foundry VTT changes. This will mean we lose multiple language support on some macros for a bit, but it is unsustainable to maintain these with our current format.

@bithir bithir added enhancement New feature or request good first issue Good for newcomers bug Something isn't working labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant