Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move saveCombatRoll and saveAttributeRoll to client settings #670

Open
psdao1102 opened this issue Sep 24, 2024 · 1 comment
Open

Move saveCombatRoll and saveAttributeRoll to client settings #670

psdao1102 opened this issue Sep 24, 2024 · 1 comment
Labels
enhancement New feature or request FoundryVTT-v13

Comments

@psdao1102
Copy link

Hello,

I would like to suggest that saveCombatRoll and saveAttributeRoll get moved to client settings as it would be nice for it to be selected as a pc, but not necissarily as a GM who has to move between many different characters.

my understanding is that we would have to change

 game.settings.register('symbaroum', 'saveCombatRoll', {
    name: 'SYMBAROUM.OPTIONAL_SAVECOMBATROLL',
    hint: 'SYMBAROUM.OPTIONAL_SAVECOMBATROLL_HINT',
    scope: 'world',
    type: Boolean,
    default: false,
    config: true
  });
  game.settings.register('symbaroum', 'saveAttributeRoll', {
    name: 'SYMBAROUM.OPTIONAL_SAVEATTRIBUTEROLL',
    hint: 'SYMBAROUM.OPTIONAL_SAVEATTRIBUTEROLL_HINT',
    scope: 'world',
    type: Boolean,
    default: false,
    config: true
  });

to be client instead of world.

Thank you!

@bithir
Copy link
Collaborator

bithir commented Oct 17, 2024

I'm going to park this one for Foundry VTT v13. It will introduce a new scope, 'user', which would suite these settings much better than 'client' would.

See API improvements on https://foundryvtt.com/releases/13.332

@bithir bithir added enhancement New feature or request FoundryVTT-v13 labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FoundryVTT-v13
Projects
None yet
Development

No branches or pull requests

2 participants