Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CLI architecture and refactoring #129

Open
fpliger opened this issue Aug 18, 2023 · 1 comment
Open

Improve CLI architecture and refactoring #129

fpliger opened this issue Aug 18, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@fpliger
Copy link
Contributor

fpliger commented Aug 18, 2023

The current implementation basically shoves all the logic inside _generator.py in a way that makes it very hard to add new commands and re-use logic or extend the command with, for instance, new project types. We need a better architecture that allows to declare/hook in new project types using different templates so that we can allow new project types we have in the roadmap (asgi type is what I'm currently working on but also plugin is definitely something coming up in the future.

Ideally, the create cmd should take care of collecting all the shared into that the create cmd needs, take care of common tasks (like creating the folder or a config file) and then delegating to any custom hooks that are registered to handle new project types.

@FabioRosado
Copy link
Contributor

Agreed, I think this is also valid not just for the create but for the run command. The whole CLI needs refactoring, I'm going to update the title to reflect this and try to work on it in the future

@FabioRosado FabioRosado changed the title Improve create command architecture Improve CLI architecture and refactoring Feb 28, 2024
@FabioRosado FabioRosado added the enhancement New feature or request label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants