Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option for SPA #132

Open
eruvanos opened this issue Sep 28, 2023 · 6 comments
Open

Add an option for SPA #132

eruvanos opened this issue Sep 28, 2023 · 6 comments
Labels
question Further information is requested

Comments

@eruvanos
Copy link

For single page applications it would be great to have a spa modus, which serves a default (often just index.html) page in case there is no matching file within the folder.

Example (old Python):
https://gist.github.com/jtangelder/e445e9a7f5e31c220be6

@FabioRosado
Copy link
Contributor

Hello I am going through the open issues and triaging them before we do another release of the CLI.

Currently (in main) we have a pyscript run which runs a web server in a folder and serves whatever is there, even if index.html isn't available.

Does this do what you expect or you mean something else?

@FabioRosado FabioRosado added the question Further information is requested label Feb 28, 2024
@eruvanos
Copy link
Author

Hi,
to serve some SPA setups, it is required, to always serve index.html for any route, except for those which actually refer to an existing file to serve.

This way the routing can use path based routing ("/") instead of "#/".

@FabioRosado
Copy link
Contributor

What exactly would you propose we change in the CLI for this?

@eruvanos
Copy link
Author

Maybe a --default <file>.html parameter would be a good option, which always returns the given file if the requested path does not exist.

So it would be flexible and would not be tied down to the SPA use case.

@FabioRosado
Copy link
Contributor

Ah I understand now 😄

You can pass a path to pyscript run so for example assume you have a main.html you can do pyscript run main.html and it will serve that file as soon as the server starts. Will this address your use case? 🤔

@eruvanos
Copy link
Author

No, it requires to always answer with the index file, if the path does not exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants