please make applying the umask configurable for create_dir() #1038
Labels
Comments
|
Sure, that makes sense - I hadn't thought about this at the time. |
mrbean-bremen
added a commit
to mrbean-bremen/pyfakefs
that referenced
this issue
Jul 11, 2024
* allows to ignore the umask * closes pytest-dev#1038
6 tasks
|
I guess you will need a release with the change? |
|
A new release is out. |
joecool1029
added a commit
to joecool1029/gentoo
that referenced
this issue
Jul 18, 2024
Spoken with upstream, this is fixed in 4.3.3 (which uses newer pyfakefs). Caused by pytest-dev/pyfakefs#1038 Signed-off-by: Joe Kappus <joe@wt.gd>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this issue
Jul 20, 2024
Spoken with upstream, this is fixed in 4.3.3 (which uses newer pyfakefs). Caused by pytest-dev/pyfakefs#1038 Signed-off-by: Joe Kappus <joe@wt.gd> Closes: #36990 Signed-off-by: Joonas Niilola <juippis@gentoo.org>
|
@mrbean-bremen Couldn't respond timely as I found myself completely AFK the last four weeks, but still: thanks for the quick fix and the new release. |
|
Thanks @mrbean-bremen ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Recent changes made pyfakefs apply the umask by default when creating files or dirs. For
create_file(), this behaviour is configurable via theapply_umaskparameter. Please add a similar parameter forcreate_dir(), to allow for ignoring the umask and thus enabling full control of the exact permissions on the new dir via theperm_bitsparameter.Currently, we work around the umask always getting applied to directories by configuring an unrealistic all-permissive umask ("0000") on the fake filesystem (like so) to get rid of some test failures (sabnzbd/sabnzbd#2883). Having an option to control the behaviour of
create_dir()would obviously be a lot nicer.The text was updated successfully, but these errors were encountered: