-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebUI default background color #21894
Comments
Yeah, that's another consequence of not setting the background color explicitly. @skomerko, @Piccirello, maybe we just drop in the background color. |
Yes, notice that unlike PR #21498 my report is not for dark theme, what you see in the screenshot is the default light theme, only within Organizr that has a black background by default. This is the same page accessed directly, with Chrome using a white background color |
Will #21914 be enough to fix your issue? |
Yep,
In my specific case I configured Organizr to add a CSS rule to the iframe so it had a proper background. |
This PR ensures that the same base background color is used across different browsers (more consistent styling). Context: #21498 (comment) Used default Chrome colors: #21894 (comment) PR #21914.
qBittorrent & operating system versions
qBittorrent: v5.0.2 (I guess, that's what WebUI's About dialog says)
Operating system: Void Linux
Qt: 6.8.0
Libtorrent: 1.2.19.0
Additional deps:
Boost: 1.86.0
OpenSSL: 3.4.0
zlib: 1.3.1.zlib-ng
What is the problem?
The CSS seems to rely on browsers default white background color, thus uses rgb(0,0,0,0) where it means "white".
When embedded in an iframe with a different background (e.g. in Organizr) this results in very poor readability.
The app should set the base background color it relies on, for instance setting
background color: white
onbody
elementSteps to reproduce
body
elementbackground-color: black;
to the element styleAdditional context
Log(s) & preferences file(s)
There are no logs or preference involved.
The text was updated successfully, but these errors were encountered: