Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Background color issue for GitHub icon on dark theme #9

Open
eugene4545 opened this issue Jun 7, 2024 · 1 comment
Open

Comments

@eugene4545
Copy link

Description

I'm experiencing an issue with the GitHub icon's background color when viewed on a dark theme. The icon is not clearly visible, and attempts to change the background color using inline styles have not been successful. Here are the steps I followed:

  1. I tried adding a style attribute directly to the <td> element:
<td align="center" width="96" style="background-color: white;">
    <img src="https://techstack-generator.vercel.app/github-icon.svg" width="48" height="48" alt="GitHub" /><br>GitHub
</td>
  1. I also wrapped the icon in a div with a white background:
<td align="center" width="96">
    <div style="background-color: white; padding: 10px; border-radius: 10px;">
        <img src="https://techstack-generator.vercel.app/github-icon.svg" width="48" height="48" alt="GitHub" /><br>GitHub
    </div>
</td>

Despite these efforts, the background color does not change, and the icon remains difficult to see on dark themes.

Steps to Reproduce

  1. Create an HTML table with the provided <td> elements.
  2. Apply the inline styles as shown.
  3. View the table on a dark theme.

Expected Behavior

The Particular GitHub icon should have a white background to ensure its animation is visible on dark themes.

Actual Behavior

The background color does not change, and the icon remains hard to see.

Environment

  • Browser: Chrome
  • Any additional tools or frameworks: None

Please provide guidance on how to resolve this issue or update the icon generator to support background color changes.

Thanks for all the great work on these tools—they're really helpful!

@eugene4545 eugene4545 changed the title [fix]: Background color issue for GitHub icon on dark theme [bug]: Background color issue for GitHub icon on dark theme Jun 7, 2024
@qkrdmstlr3
Copy link
Owner

Thank you for letting me know! I'll check it out as soon as possible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants