Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FluxTunableTransmon and Transmon question #87

Open
liorella-qm opened this issue Mar 21, 2022 · 2 comments
Open

FluxTunableTransmon and Transmon question #87

liorella-qm opened this issue Mar 21, 2022 · 2 comments
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@liorella-qm
Copy link
Contributor

liorella-qm commented Mar 21, 2022

in FluxTunableTransmon and Transmon:

  1. why is mixer optional? We'd always want to upconvert the signals, no? Is it for a scenario where you don't want to do mixer calibration at all? Is it even possible to define an IQ element without mixer in the config schema?
  2. intermediate frequency should not be an int type. Probably the best thing to do is to set it to a float, this leads to desired behavior when you copy-paste into pycharm:
import numpy as np


def foo(x: float):
    print(x)
    

foo(2)
foo(2.3)
foo(4.5 + 1j)  # warning
ar = np.array(3)
foo(ar)  # warning
ar2 = np.array([2, 3])
foo(ar2[0])
foo(ar2)  # warning
@liorella-qm liorella-qm added question Further information is requested bug Something isn't working labels Mar 21, 2022
@qguyk
Copy link
Contributor

qguyk commented Mar 21, 2022

regarding 1 - it's optional because you don't have to define all in the init of the object.
you can later add a mixer.
@SatyaBade12 maybe we should add a validation in get_elements function that there is a mixer

@yomach
Copy link
Collaborator

yomach commented Mar 21, 2022

"Is it even possible to define an IQ element without mixer in the config schema?"

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants