-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publication failed after merge of new release YAML files #293
Comments
I think it might be due to quarkus-logging-splunk/pom.xml Lines 57 to 71 in 5c9ec61
Do you still need the Splunk repository there? Anyway, pinging @gastaldi as he will know more. |
@aalmiray looks like this is another validation that can be relaxed in Jreleaser |
Pomchecker has a Could be done with both |
For info we need the 2nd repository as com.splunk.logging:splunk-library-javalogging is not published to Maven central (splunk/splunk-library-javalogging#17) |
The |
I'll get the fix done in JReleaser this weekend. You'll be able to use it via its |
My experience is that if you remove Central, the other repository will be contacted first - which might be slow and annoying. |
I wonder if it's possible to shade this dependency in the extension's runtime, then the repository can be removed completely |
Well, you will need the repository to download the dependency anyway. Given Andres said he would provide a fix soon, we can probably just wait. |
Indeed you're right:
|
You'll get used to it :] |
Yes, but that will be there only while building the binary, then the shade plugin will remove it from the pom.xml (assuming the repository element is moved to the runtime/pom.xml) |
Yeah, can't say I'm a big fan of shading. Now I have no idea if this extension is just a small thing with no security issues and a few classes or something that might be problematic in the end. |
Rather use the flatten plugin to rewrite the pom to-be-published after shading. |
Ready jreleaser/jreleaser@50d4915
|
The split release scripts were merged on the quarkus-logging-splunk Quarkiverse extension.
A release was attempted with the new scripts and it does not seem to work:
Here is the link to the failed publication: https://github.com/quarkiverse/quarkiverse-release/actions/runs/11497223021/job/32000478343
Is there something missing from the POM perspective for instance?
The text was updated successfully, but these errors were encountered: