Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publication failed after merge of new release YAML files #293

Open
edeweerd1A opened this issue Oct 25, 2024 · 15 comments
Open

Publication failed after merge of new release YAML files #293

edeweerd1A opened this issue Oct 25, 2024 · 15 comments

Comments

@edeweerd1A
Copy link
Contributor

The split release scripts were merged on the quarkus-logging-splunk Quarkiverse extension.
A release was attempted with the new scripts and it does not seem to work:

The POM file
/home/runner/work/quarkiverse-release/quarkiverse-release/repository/io/quarkiverse/logging/splunk/quarkus-logging-splunk-parent/4.0.0/quarkus-logging-splunk-parent-4.0.0.pom
cannot be uploaded to Maven Central due to the following reasons:
 * The <repositories> block should not be present.

Here is the link to the failed publication: https://github.com/quarkiverse/quarkiverse-release/actions/runs/11497223021/job/32000478343

Is there something missing from the POM perspective for instance?

@gsmet
Copy link
Member

gsmet commented Oct 25, 2024

I think it might be due to

<repositories>
<repository>
<id>central</id>
<name>Central Repository</name>
<url>https://repo.maven.apache.org/maven2</url>
<snapshots>
<enabled>false</enabled>
</snapshots>
</repository>
<repository>
<id>splunk</id>
<name>Splunk Releases</name>
<url>https://splunk.jfrog.io/splunk/ext-releases-local</url>
</repository>
</repositories>
. But not sure why we are enforcing that.

Do you still need the Splunk repository there?

Anyway, pinging @gastaldi as he will know more.

@gastaldi
Copy link
Member

@aalmiray looks like this is another validation that can be relaxed in Jreleaser

@gastaldi gastaldi transferred this issue from quarkiverse/quarkiverse-devops Oct 25, 2024
@aalmiray
Copy link

aalmiray commented Oct 25, 2024

Pomchecker has a --no-strict flag that can be used to skip this check. I think JReleaser should have an option to pass additional flags to pomchecker.

Could be done with both artifactOverrides (targeted) or at the deployer level (global).

@rquinio1A
Copy link
Member

For info we need the 2nd repository as com.splunk.logging:splunk-library-javalogging is not published to Maven central (splunk/splunk-library-javalogging#17)

@gastaldi
Copy link
Member

The central can be removed, but that shouldn't prevent publishing to Central AFAIK, I'll see what I can do

@aalmiray
Copy link

I'll get the fix done in JReleaser this weekend. You'll be able to use it via its early-access builds for the time being til 1.15.0 is released at the end of the month.

@gsmet
Copy link
Member

gsmet commented Oct 25, 2024

My experience is that if you remove Central, the other repository will be contacted first - which might be slow and annoying.

@gastaldi
Copy link
Member

I wonder if it's possible to shade this dependency in the extension's runtime, then the repository can be removed completely

@gsmet
Copy link
Member

gsmet commented Oct 25, 2024

Well, you will need the repository to download the dependency anyway. Given Andres said he would provide a fix soon, we can probably just wait.

@rquinio1A
Copy link
Member

My experience is that if you remove Central, the other repository will be contacted first - which might be slow and annoying.

Indeed you're right:

[INFO] Scanning for projects...
Downloading from splunk: https://splunk.jfrog.io/splunk/ext-releases-local/io/quarkus/quarkus-bom/3.15.0.CR1/quarkus-b
om-3.15.0.CR1.pom
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-bom/3.15.0.CR1/quarkus-bom-3.15.0.CR
1.pom
Downloaded from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-bom/3.15.0.CR1/quarkus-bom-3.15.0.CR1
.pom (471 kB at 1.9 MB/s)

@gsmet
Copy link
Member

gsmet commented Oct 25, 2024

Indeed you're right:

You'll get used to it :]

@gastaldi
Copy link
Member

Well, you will need the repository to download the dependency anyway.

Yes, but that will be there only while building the binary, then the shade plugin will remove it from the pom.xml (assuming the repository element is moved to the runtime/pom.xml)

@gsmet
Copy link
Member

gsmet commented Oct 25, 2024

Yeah, can't say I'm a big fan of shading. Now I have no idea if this extension is just a small thing with no security issues and a few classes or something that might be problematic in the end.

@aalmiray
Copy link

Well, you will need the repository to download the dependency anyway.

Yes, but that will be there only while building the binary, then the shade plugin will remove it from the pom.xml (assuming the repository element is moved to the runtime/pom.xml)

Rather use the flatten plugin to rewrite the pom to-be-published after shading.

@aalmiray
Copy link

Ready jreleaser/jreleaser@50d4915
Simply set pomchecker's strict property to false

deploy:
  maven:
    pomchecker:
      strict: false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants