Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Verify files with PGP keys wherever possible. #4

Open
1 task done
lj3954 opened this issue Jul 11, 2024 · 1 comment
Open
1 task done

feat: Verify files with PGP keys wherever possible. #4

lj3954 opened this issue Jul 11, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@lj3954
Copy link
Member

lj3954 commented Jul 11, 2024

I confirm this feature has not been previously requested

  • I have searched the issues and this feature has not previously been requested

Describe the solution you'd like
Quickget should be able to verify files with PGP keys, or other more secure methods, whenever such is available. This would improve security. Quickget_configs must provide these keys, within the WebSource struct. In addition, the json files distributed through CI should also be signed, to ensure that there's virtually no chance of tampering

Describe alternatives you've considered
There are no alternatives. The current method of using checksums fetched from the same mirror (which, to be clear, should still be done in addition) is not anywhere near as secure as PGP keys. It more or less serves to verify that the file you downloaded matches the file on the server, rather than what the source of the file is.

Additional context
PGP keys must be added as constant values, and never fetched from the internet in CI or at any point. That would defeat the entire purpose. Obviously, care must be taken to ensure that the keys are correct for the maintainers of each project.

@lj3954 lj3954 added the enhancement New feature or request label Jul 11, 2024
@lj3954 lj3954 self-assigned this Jul 11, 2024
@lj3954
Copy link
Member Author

lj3954 commented Jul 16, 2024

Nearly all distros sign only checksum files, so this should be added to the checksum building logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant