New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify three false conditions for r_vector string #431

Open

pachadotdev opened this issue Jan 1, 2025 · 0 comments

Contributor

pachadotdev commented Jan 1, 2025

Is there a better condition we could use, e.g. assert something true rather than three things false? https://github.com/r-lib/cpp11/blob/main/inst/include/cpp11/r_vector.hpp#L1395

Still using 3 conditions, I think it is simpler to ensure that C is not constructible from SEXP, and neither C nor T is a std::string.

pachadotdev added a commit to pachadotdev/cpp11 that referenced this issue


          implement r-lib#431

6f84867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment