Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing reference to 'pattern' in new error message for mis-specified expect_condition() #2053

Open
MichaelChirico opened this issue Jan 15, 2025 · 0 comments · May be fixed by #2055
Open

Confusing reference to 'pattern' in new error message for mis-specified expect_condition() #2053

MichaelChirico opened this issue Jan 15, 2025 · 0 comments · May be fixed by #2055

Comments

@MichaelChirico
Copy link
Contributor

testthat/R/expect-condition.R

Line 299 in 50a99ec

"Can't specify {.arg ...} without {.arg pattern}.",

AFAICT pattern= is an internal-only argument; the user-facing argument is always called regexp=:

https://testthat.r-lib.org/reference/expect_error.html
@MichaelChirico MichaelChirico changed the title Confusing reference to 'pattern' Confusing reference to 'pattern' in new error message for mis-specified expect_condition() Jan 15, 2025
This was referenced Jan 15, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@MichaelChirico