Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validation logic for the CALENDAR_QUARTER field #2807

Closed
9 tasks
ADPennington opened this issue Jan 9, 2024 · 1 comment · Fixed by #2889
Closed
9 tasks

Update validation logic for the CALENDAR_QUARTER field #2807

ADPennington opened this issue Jan 9, 2024 · 1 comment · Fixed by #2889
Assignees

Comments

@ADPennington
Copy link
Collaborator

ADPennington commented Jan 9, 2024

Description

The validation on the CALENDAR_QUARTER field (present in Section 3 and 4 files for TANF, SSP, and Tribal TANF schemas) needs an update to better handle out of range year and quarter values.

  • if this field is not valid, OFA cannot infer the reporting period that the record covers. this record cannot be used for analysis.

  • for dateYearIsLargerThan, TDP currently accepts data for FY2021 and forward, so valid year values >= 2020 (because FY2021 Q1 == Oct - Dec, 2020)

  • for the quarterIsValid, Valid quarter values are 1, 2, 3, or 4.

  • If the quarter is a space, currently no error is raised in the logs or the feedback report.

  • if the quarter = 0 or > 4, currently this message is returned in the logs Invalid quarter value. and the processing status stays in the "pending" state and a feedback report is not generated.

Originally posted by @ADPennington in #2762 (comment)

Acceptance Criteria:

  • record with out-of-range value (cat 2 error) for CALENDAR_QUARTER field is not stored in db.
  • validator for CALENDAR_QUARTER field is updated to properly evaluate if the value is valid.
  • feedback report generated and captures the issues with the CALENDAR_QUARTER field if a cat 2 error exists.
  • Testing Checklist has been run and all tests pass
  • README is updated, if necessary

Tasks:

  • Task 1
  • Task 2
  • Task 3
  • Run Testing Checklist and confirm all tests pass

Notes:

  • this is relevant to Section 3 and 4 files for TANF, SSP, and Tribal TANF.
  • Note 2
  • Note 3

Supporting Documentation:

  • Doc 1
  • Doc 2

Open Questions:

  • Open Question 1
  • Open Question 2
@ADPennington ADPennington changed the title [wip] update validation logic for the CALENDAR_QUARTER fields [wip] update validation logic for the CALENDAR_QUARTER field Jan 9, 2024
@ADPennington ADPennington added dev and removed WIP labels Jan 17, 2024
@ADPennington ADPennington changed the title [wip] update validation logic for the CALENDAR_QUARTER field Update validation logic for the CALENDAR_QUARTER field Jan 17, 2024
@jtimpe
Copy link

jtimpe commented Jan 23, 2024

#2799 + #2711 make updates to the RPT_MONTH_YEAR preparsing + field validators
#2793 validator logic for RPT_MONTH_YEAR

will re-discuss AC as work on above is completed, allowed range for quarter should still throw a parser error

@atrimpe atrimpe assigned atrimpe and unassigned jtimpe Mar 6, 2024
@atrimpe atrimpe mentioned this issue Mar 15, 2024
30 tasks
@elipe17 elipe17 self-assigned this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants