Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CapiProvider edit behaviour #104

Open
mantis-toboggan-md opened this issue Nov 26, 2024 · 2 comments
Open

Improve CapiProvider edit behaviour #104

mantis-toboggan-md opened this issue Nov 26, 2024 · 2 comments
Assignees

Comments

@mantis-toboggan-md
Copy link
Member

We need to determine which of the CapiProvider fields are editable: currently, the UI allows users to change everything except name and namespace with the built-in provider options. The custom capiprovider edit options are more limited -- there is a related issue where we are not showing those input fields, but we have the same problem re: not knowing which should be editable.

An additional, related concern is if and when users should be allowed to delete these capiproviders. Currently, deletion is unrestricted.

create options:
Screenshot 2024-11-26 at 8 20 26 AM
Screenshot 2024-11-26 at 8 24 36 AM

edit options:
Screenshot 2024-11-26 at 8 27 42 AM
Screenshot 2024-11-26 at 8 20 34 AM

@mantis-toboggan-md
Copy link
Member Author

I filed a separate issue to look into the hidden fields when editing custom providers; it looks like a UI bug to me #105

@Danil-Grigorev
Copy link

Danil-Grigorev commented Nov 26, 2024

From the high level overview, editable should be:

  1. Description
  2. Version + version can be set to empty to use latest
  3. Anything in the secrets section
  4. Anything in the Features section
  5. Anything in the Variables section

No need to provide defaults for these features on creation/edit, it is best to rely on turtles defaults per provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants