Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests are out of date #28

Open
danielweck opened this issue Feb 1, 2017 · 0 comments
Open

Unit tests are out of date #28

danielweck opened this issue Feb 1, 2017 · 0 comments

Comments

@danielweck
Copy link
Member

danielweck commented Feb 1, 2017 •
edited
Loading

https://github.com/readium/readium-lcp-client/tree/develop/test/lcp-client-lib

For example: lcp::Status res = m_lcpService->OpenLicense(mobyDickLicenseStr, &license); function signature changed to:

    Status LcpService::OpenLicense(
            const std::string & publicationPath,
            const std::string & licenseJson,
            ILicense** licensePTR)

https://github.com/readium/readium-lcp-client/blob/develop/test/lcp-client-lib/tests/LcpServiceTest.cpp#L72

vs.

https://github.com/readium/readium-lcp-client/blob/develop/src/lcp-client-lib/LcpService.cpp#L136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielweck