Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize naming conventions across the API #95

Closed
wetneb opened this issue Jul 28, 2022 · 3 comments
Closed

Normalize naming conventions across the API #95

wetneb opened this issue Jul 28, 2022 · 3 comments

Comments

@wetneb
Copy link
Member

wetneb commented Jul 28, 2022

In the manifest we have fields such as identifierSpace and feature_view.
We should settle on a style: either identifierSpace and featureView, or identifier_space and feature_view.

I think in JSON it is somehow more common to have feature_view than featureView.
@thadguidry
Copy link
Contributor

Agree, underscore separation

@wetneb
Copy link
Member Author

wetneb commented Jul 29, 2022

Yeah but on the other side, the identifierSpace and schemaSpace have been there for ages, whereas feature_view, so it would likely be much less disruptive to rename the latter…

@thadguidry thadguidry mentioned this issue Apr 11, 2024
Closed
@fsteeg
Copy link
Member

fsteeg commented Jul 11, 2024

Resolved with #166 (PR for #150, which was a duplicate of this), closing.

@fsteeg fsteeg closed this as completed Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fsteeg @wetneb @thadguidry