From b1044f4c3539cb00d68c614e500830019ea0e238 Mon Sep 17 00:00:00 2001 From: Akira Yokochi Date: Sat, 14 Dec 2024 12:29:44 +0900 Subject: [PATCH 1/2] Fix some docs (playbook name and more) (#1012) * fix YAML example in controller_credential_input_sources README * fix prefixes in CONVERSION_GUIDE * fix Playbook in README --- CONVERSION_GUIDE.md | 6 +++--- README.md | 2 +- roles/controller_credential_input_sources/README.md | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/CONVERSION_GUIDE.md b/CONVERSION_GUIDE.md index dbf6f2b27..b4f3ef40c 100644 --- a/CONVERSION_GUIDE.md +++ b/CONVERSION_GUIDE.md @@ -192,9 +192,9 @@ This is the format that is used for each using the appropriate prefix Prefixes -- controller_configuration -- ah_configuration -- gateway +- controller_configuration_ +- ah_configuration_ +- gateway_ - eda_configuration_ Format: diff --git a/README.md b/README.md index bcef36ea9..bef7eae83 100644 --- a/README.md +++ b/README.md @@ -81,7 +81,7 @@ The awx.awx or ansible.controller collection must be invoked in the playbook in The following command will invoke the collection playbook. This is considered a starting point for the collection. ```console -ansible-playbook infra.aap_configuration.configure_controller.yml +ansible-playbook infra.aap_configuration.configure_aap.yml ``` Otherwise it will look for the modules only in your base installation. If there are errors complaining about "couldn't resolve module/action" this is the most likely cause. diff --git a/roles/controller_credential_input_sources/README.md b/roles/controller_credential_input_sources/README.md index 08567957a..3e4849151 100644 --- a/roles/controller_credential_input_sources/README.md +++ b/roles/controller_credential_input_sources/README.md @@ -132,7 +132,7 @@ controller_credential_input_sources: secret_path: vault/path/to/gitlab/secret auth_path: approle secret_key: GITLAB_PASSWORD_FROM_HASHI_VAULT - secret_version + secret_version: v2 description: Fill the gitlab credential from HashiCorp Vault - source_credential: cyberark target_credential: gitlab From d35606856bc72dbd16f8c20d5935e1c2f8a7217f Mon Sep 17 00:00:00 2001 From: Tom Page Date: Sat, 14 Dec 2024 07:30:30 +0000 Subject: [PATCH 2/2] Update pre-commit (#1009) Co-authored-by: sean-m-sullivan --- .pre-commit-config.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index b585c3793..38f3072fe 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -6,7 +6,7 @@ repos: - id: end-of-file-fixer - id: trailing-whitespace - repo: https://github.com/ansible-community/ansible-lint.git - rev: v24.12.1 + rev: v24.12.2 hooks: # see discussions here about what arguments are used, and behavior # https://github.com/ansible/ansible-lint/issues/649