Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong default value for workflow_job_templates limit #724

Closed
bogdanmuresan opened this issue Nov 13, 2023 · 2 comments
Closed

Wrong default value for workflow_job_templates limit #724

bogdanmuresan opened this issue Nov 13, 2023 · 2 comments
Labels
bug Something isn't working inactive No movement has happened in 30 days

Comments

@bogdanmuresan
Copy link
Contributor

bogdanmuresan commented Nov 13, 2023

https://github.com/redhat-cop/controller_configuration/blob/devel/roles/workflow_job_templates/tasks/main.yml#L13

Default value set for workflow templates limit is 0, but I think this should be empty string.

@bogdanmuresan bogdanmuresan added bug Something isn't working new New issue, this should be removed once reviewed labels Nov 13, 2023
@sean-m-sullivan
Copy link
Collaborator

it should match this as empty string, yes
https://github.com/redhat-cop/controller_configuration/blob/a79f987765ae7d6ba5763c6d45c56ea7d325ec3f/roles/job_templates/tasks/main.yml#L17C145-L17C145

Funnily enough the job template api/v2/job_templates OPTIONS lists it as "", however workflow_job_template OPTIONS lists it as null.

@djdanielsson djdanielsson removed the new New issue, this should be removed once reviewed label Dec 1, 2023
@ivarmu
Copy link
Contributor

ivarmu commented Dec 7, 2023

This issue should be resolved as the #729 had been merged, shouldn't it?

@github-actions github-actions bot added the inactive No movement has happened in 30 days label Jan 7, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working inactive No movement has happened in 30 days
Projects
None yet
Development

No branches or pull requests

5 participants