From b47e32d675484cb5802308c0415371e4cd6d3204 Mon Sep 17 00:00:00 2001 From: MallocArray Date: Wed, 11 Dec 2024 10:01:35 -0600 Subject: [PATCH 1/5] Fix loop label in controller_execution_environments --- roles/controller_execution_environments/tasks/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/controller_execution_environments/tasks/main.yml b/roles/controller_execution_environments/tasks/main.yml index 61c00a98d..12d554ff3 100644 --- a/roles/controller_execution_environments/tasks/main.yml +++ b/roles/controller_execution_environments/tasks/main.yml @@ -21,7 +21,7 @@ loop: "{{ execution_environments if execution_environments is defined else controller_execution_environments }}" loop_control: loop_var: __execution_environments_item - label: "{{ __operation.verb }} Controller Execution Environment {{ __execution_environments_item }}" + label: "{{ __operation.verb }} Controller Execution Environment {{ __execution_environments_item.name }}" pause: "{{ controller_configuration_execution_environments_loop_delay }}" no_log: "{{ controller_configuration_execution_environments_secure_logging }}" when: controller_execution_environments is defined From b5cc5282b96890a83f731886213c71e1bc21422e Mon Sep 17 00:00:00 2001 From: Joshua Post Date: Wed, 11 Dec 2024 12:34:48 -0600 Subject: [PATCH 2/5] Correct spelling of recommended and configuration --- .github/workflows/office-hours-issue.yml | 2 +- roles/controller_applications/README.md | 4 ++-- roles/controller_credential_input_sources/README.md | 4 ++-- roles/controller_credential_types/README.md | 4 ++-- roles/controller_execution_environments/README.md | 4 ++-- roles/controller_host_groups/README.md | 4 ++-- roles/controller_hosts/README.md | 4 ++-- roles/controller_instance_groups/README.md | 4 ++-- roles/controller_instances/README.md | 4 ++-- roles/controller_inventories/README.md | 4 ++-- roles/controller_inventory_sources/README.md | 4 ++-- roles/controller_job_templates/README.md | 4 ++-- roles/controller_license/README.md | 2 +- roles/controller_notification_templates/README.md | 4 ++-- roles/controller_organizations/README.md | 4 ++-- roles/controller_projects/README.md | 4 ++-- roles/controller_roles/README.md | 4 ++-- roles/controller_schedules/README.md | 4 ++-- roles/controller_teams/README.md | 4 ++-- roles/controller_users/README.md | 4 ++-- roles/controller_workflow_job_templates/README.md | 4 ++-- roles/gateway_applications/README.md | 4 ++-- roles/gateway_service_nodes/README.md | 4 ++-- 23 files changed, 44 insertions(+), 44 deletions(-) diff --git a/.github/workflows/office-hours-issue.yml b/.github/workflows/office-hours-issue.yml index cc03f2143..99ab4203e 100644 --- a/.github/workflows/office-hours-issue.yml +++ b/.github/workflows/office-hours-issue.yml @@ -53,7 +53,7 @@ jobs: As well as the monthly video meeting you can join the Community (inc development team) on Matrix Chat. - - Matrix: [#aap_config_as_code:ansible.com](https://matrix.to/#/#aap_config_as_code:ansible.com) (recomended) + - Matrix: [#aap_config_as_code:ansible.com](https://matrix.to/#/#aap_config_as_code:ansible.com) (recommended) ## Past Recordings diff --git a/roles/controller_applications/README.md b/roles/controller_applications/README.md index 7bd8014f9..25db4f2dc 100644 --- a/roles/controller_applications/README.md +++ b/roles/controller_applications/README.md @@ -30,9 +30,9 @@ Currently: The following Variables compliment each other. If Both variables are not set, enforcing default values is not done. Enabling these variables enforce default values on options that are optional in the controller API. -This should be enabled to enforce configuration and prevent configuration drift. It is recomended to be enabled, however it is not enforced by default. +This should be enabled to enforce configuration and prevent configuration drift. It is recommended to be enabled, however it is not enforced by default. -Enabling this will enforce configurtion without specifying every option in the configuration files. +Enabling this will enforce configuration without specifying every option in the configuration files. 'controller_configuration_applications_enforce_defaults' defaults to the value of 'aap_configuration_enforce_defaults' if it is not explicitly called. This allows for enforced defaults to be toggled for the entire suite of controller configuration roles with a single variable, or for the user to selectively use it. diff --git a/roles/controller_credential_input_sources/README.md b/roles/controller_credential_input_sources/README.md index 285bc6d11..08567957a 100644 --- a/roles/controller_credential_input_sources/README.md +++ b/roles/controller_credential_input_sources/README.md @@ -30,9 +30,9 @@ Currently: The following Variables compliment each other. If Both variables are not set, enforcing default values is not done. Enabling these variables enforce default values on options that are optional in the controller API. -This should be enabled to enforce configuration and prevent configuration drift. It is recomended to be enabled, however it is not enforced by default. +This should be enabled to enforce configuration and prevent configuration drift. It is recommended to be enabled, however it is not enforced by default. -Enabling this will enforce configurtion without specifying every option in the configuration files. +Enabling this will enforce configuration without specifying every option in the configuration files. 'controller_configuration_credential_input_sources_enforce_defaults' defaults to the value of 'aap_configuration_enforce_defaults' if it is not explicitly called. This allows for enforced defaults to be toggled for the entire suite of controller configuration roles with a single variable, or for the user to selectively use it. diff --git a/roles/controller_credential_types/README.md b/roles/controller_credential_types/README.md index 0252beda7..6e5a0e20e 100644 --- a/roles/controller_credential_types/README.md +++ b/roles/controller_credential_types/README.md @@ -30,9 +30,9 @@ Currently: The following Variables compliment each other. If Both variables are not set, enforcing default values is not done. Enabling these variables enforce default values on options that are optional in the controller API. -This should be enabled to enforce configuration and prevent configuration drift. It is recomended to be enabled, however it is not enforced by default. +This should be enabled to enforce configuration and prevent configuration drift. It is recommended to be enabled, however it is not enforced by default. -Enabling this will enforce configurtion without specifying every option in the configuration files. +Enabling this will enforce configuration without specifying every option in the configuration files. 'controller_configuration_credential_types_enforce_defaults' defaults to the value of 'aap_configuration_enforce_defaults' if it is not explicitly called. This allows for enforced defaults to be toggled for the entire suite of controller configuration roles with a single variable, or for the user to selectively use it. diff --git a/roles/controller_execution_environments/README.md b/roles/controller_execution_environments/README.md index fbf91ef3b..2627c6f4b 100644 --- a/roles/controller_execution_environments/README.md +++ b/roles/controller_execution_environments/README.md @@ -30,9 +30,9 @@ Currently: The following Variables compliment each other. If Both variables are not set, enforcing default values is not done. Enabling these variables enforce default values on options that are optional in the controller API. -This should be enabled to enforce configuration and prevent configuration drift. It is recomended to be enabled, however it is not enforced by default. +This should be enabled to enforce configuration and prevent configuration drift. It is recommended to be enabled, however it is not enforced by default. -Enabling this will enforce configurtion without specifying every option in the configuration files. +Enabling this will enforce configuration without specifying every option in the configuration files. 'controller_configuration_execution_environments_enforce_defaults' defaults to the value of 'aap_configuration_enforce_defaults' if it is not explicitly called. This allows for enforced defaults to be toggled for the entire suite of controller configuration roles with a single variable, or for the user to selectively use it. diff --git a/roles/controller_host_groups/README.md b/roles/controller_host_groups/README.md index 0626f4590..a75ea15e2 100644 --- a/roles/controller_host_groups/README.md +++ b/roles/controller_host_groups/README.md @@ -30,9 +30,9 @@ Currently: The following Variables compliment each other. If Both variables are not set, enforcing default values is not done. Enabling these variables enforce default values on options that are optional in the controller API. -This should be enabled to enforce configuration and prevent configuration drift. It is recomended to be enabled, however it is not enforced by default. +This should be enabled to enforce configuration and prevent configuration drift. It is recommended to be enabled, however it is not enforced by default. -Enabling this will enforce configurtion without specifying every option in the configuration files. +Enabling this will enforce configuration without specifying every option in the configuration files. 'controller_configuration_groups_enforce_defaults' defaults to the value of 'aap_configuration_enforce_defaults' if it is not explicitly called. This allows for enforced defaults to be toggled for the entire suite of controller configuration roles with a single variable, or for the user to selectively use it. diff --git a/roles/controller_hosts/README.md b/roles/controller_hosts/README.md index 498bfe544..8c73cbb95 100644 --- a/roles/controller_hosts/README.md +++ b/roles/controller_hosts/README.md @@ -30,9 +30,9 @@ Currently: The following Variables compliment each other. If Both variables are not set, enforcing default values is not done. Enabling these variables enforce default values on options that are optional in the controller API. -This should be enabled to enforce configuration and prevent configuration drift. It is recomended to be enabled, however it is not enforced by default. +This should be enabled to enforce configuration and prevent configuration drift. It is recommended to be enabled, however it is not enforced by default. -Enabling this will enforce configurtion without specifying every option in the configuration files. +Enabling this will enforce configuration without specifying every option in the configuration files. 'controller_configuration_host_enforce_defaults' defaults to the value of 'aap_configuration_enforce_defaults' if it is not explicitly called. This allows for enforced defaults to be toggled for the entire suite of controller configuration roles with a single variable, or for the user to selectively use it. diff --git a/roles/controller_instance_groups/README.md b/roles/controller_instance_groups/README.md index 375eb6acf..f0cd6989d 100644 --- a/roles/controller_instance_groups/README.md +++ b/roles/controller_instance_groups/README.md @@ -30,9 +30,9 @@ Currently: The following Variables compliment each other. If Both variables are not set, enforcing default values is not done. Enabling these variables enforce default values on options that are optional in the controller API. -This should be enabled to enforce configuration and prevent configuration drift. It is recomended to be enabled, however it is not enforced by default. +This should be enabled to enforce configuration and prevent configuration drift. It is recommended to be enabled, however it is not enforced by default. -Enabling this will enforce configurtion without specifying every option in the configuration files. +Enabling this will enforce configuration without specifying every option in the configuration files. 'controller_configuration_instance_groups_enforce_defaults' defaults to the value of 'aap_configuration_enforce_defaults' if it is not explicitly called. This allows for enforced defaults to be toggled for the entire suite of controller configuration roles with a single variable, or for the user to selectively use it. diff --git a/roles/controller_instances/README.md b/roles/controller_instances/README.md index fc95b8dca..117ae0ef7 100644 --- a/roles/controller_instances/README.md +++ b/roles/controller_instances/README.md @@ -30,9 +30,9 @@ Currently: The following Variables compliment each other. If Both variables are not set, enforcing default values is not done. Enabling these variables enforce default values on options that are optional in the controller API. -This should be enabled to enforce configuration and prevent configuration drift. It is recomended to be enabled, however it is not enforced by default. +This should be enabled to enforce configuration and prevent configuration drift. It is recommended to be enabled, however it is not enforced by default. -Enabling this will enforce configurtion without specifying every option in the configuration files. +Enabling this will enforce configuration without specifying every option in the configuration files. 'controller_configuration_instances_enforce_defaults' defaults to the value of 'aap_configuration_enforce_defaults' if it is not explicitly called. This allows for enforced defaults to be toggled for the entire suite of controller configuration roles with a single variable, or for the user to selectively use it. diff --git a/roles/controller_inventories/README.md b/roles/controller_inventories/README.md index 443888a1d..30f460ca6 100644 --- a/roles/controller_inventories/README.md +++ b/roles/controller_inventories/README.md @@ -30,9 +30,9 @@ Currently: The following Variables compliment each other. If Both variables are not set, enforcing default values is not done. Enabling these variables enforce default values on options that are optional in the controller API. -This should be enabled to enforce configuration and prevent configuration drift. It is recomended to be enabled, however it is not enforced by default. +This should be enabled to enforce configuration and prevent configuration drift. It is recommended to be enabled, however it is not enforced by default. -Enabling this will enforce configurtion without specifying every option in the configuration files. +Enabling this will enforce configuration without specifying every option in the configuration files. 'controller_configuration_inventories_enforce_defaults' defaults to the value of 'aap_configuration_enforce_defaults' if it is not explicitly called. This allows for enforced defaults to be toggled for the entire suite of controller configuration roles with a single variable, or for the user to selectively use it. diff --git a/roles/controller_inventory_sources/README.md b/roles/controller_inventory_sources/README.md index 05c5623a5..a4baff702 100644 --- a/roles/controller_inventory_sources/README.md +++ b/roles/controller_inventory_sources/README.md @@ -30,9 +30,9 @@ Currently: The following Variables compliment each other. If Both variables are not set, enforcing default values is not done. Enabling these variables enforce default values on options that are optional in the controller API. -This should be enabled to enforce configuration and prevent configuration drift. It is recomended to be enabled, however it is not enforced by default. +This should be enabled to enforce configuration and prevent configuration drift. It is recommended to be enabled, however it is not enforced by default. -Enabling this will enforce configurtion without specifying every option in the configuration files. +Enabling this will enforce configuration without specifying every option in the configuration files. 'controller_configuration_inventory_sources_enforce_defaults' defaults to the value of 'aap_configuration_enforce_defaults' if it is not explicitly called. This allows for enforced defaults to be toggled for the entire suite of controller configuration roles with a single variable, or for the user to selectively use it. diff --git a/roles/controller_job_templates/README.md b/roles/controller_job_templates/README.md index f68d8c2ac..6d945224f 100644 --- a/roles/controller_job_templates/README.md +++ b/roles/controller_job_templates/README.md @@ -30,9 +30,9 @@ Currently: The following Variables compliment each other. If Both variables are not set, enforcing default values is not done. Enabling these variables enforce default values on options that are optional in the controller API. -This should be enabled to enforce configuration and prevent configuration drift. It is recomended to be enabled, however it is not enforced by default. +This should be enabled to enforce configuration and prevent configuration drift. It is recommended to be enabled, however it is not enforced by default. -Enabling this will enforce configurtion without specifying every option in the configuration files. +Enabling this will enforce configuration without specifying every option in the configuration files. 'controller_configuration_job_templates_enforce_defaults' defaults to the value of 'aap_configuration_enforce_defaults' if it is not explicitly called. This allows for enforced defaults to be toggled for the entire suite of controller configuration roles with a single variable, or for the user to selectively use it. diff --git a/roles/controller_license/README.md b/roles/controller_license/README.md index 2eb2dca63..2d4b2ba7a 100644 --- a/roles/controller_license/README.md +++ b/roles/controller_license/README.md @@ -68,7 +68,7 @@ The module and this role can use either a manifest file, or lookup the subscript |:---:|:---:|:---:|:---:|:---:| |`filters`|"default values"|no|str|dict of filters to use to narrow the subscription. See example below for how to use this.| |`support_level`|"Self-Support"|no|str|DEPRECATED - changed to `manifest_file` (still works as an alias)| -|`list_num`|0|no|int|List index of the subscription to use, if you want to overide the default, it is recomended to use the filters to limit the pools found.| +|`list_num`|0|no|int|List index of the subscription to use, if you want to overide the default, it is recommended to use the filters to limit the pools found.| |`pool_id`|""|no|str|Red Hat or Red Hat Satellite pool_id to attach to.| |`force`|`false`|no|bool|By default, the license will only be applied if controller is currently unlicensed or trial licensed. When force=true, the license is always applied.| |`use_lookup`|`false`|no|bool|Whether or not to lookup subscriptions.| diff --git a/roles/controller_notification_templates/README.md b/roles/controller_notification_templates/README.md index 2181b70d6..ddf589dc9 100644 --- a/roles/controller_notification_templates/README.md +++ b/roles/controller_notification_templates/README.md @@ -30,9 +30,9 @@ Currently: The following Variables compliment each other. If Both variables are not set, enforcing default values is not done. Enabling these variables enforce default values on options that are optional in the controller API. -This should be enabled to enforce configuration and prevent configuration drift. It is recomended to be enabled, however it is not enforced by default. +This should be enabled to enforce configuration and prevent configuration drift. It is recommended to be enabled, however it is not enforced by default. -Enabling this will enforce configurtion without specifying every option in the configuration files. +Enabling this will enforce configuration without specifying every option in the configuration files. 'controller_configuration_notifications_enforce_defaults' defaults to the value of 'aap_configuration_enforce_defaults' if it is not explicitly called. This allows for enforced defaults to be toggled for the entire suite of controller configuration roles with a single variable, or for the user to selectively use it. diff --git a/roles/controller_organizations/README.md b/roles/controller_organizations/README.md index bff991962..4007c9f0a 100644 --- a/roles/controller_organizations/README.md +++ b/roles/controller_organizations/README.md @@ -34,9 +34,9 @@ Currently: The following Variables compliment each other. If Both variables are not set, enforcing default values is not done. Enabling these variables enforce default values on options that are optional in the controller API. -This should be enabled to enforce configuration and prevent configuration drift. It is recomended to be enabled, however it is not enforced by default. +This should be enabled to enforce configuration and prevent configuration drift. It is recommended to be enabled, however it is not enforced by default. -Enabling this will enforce configurtion without specifying every option in the configuration files. +Enabling this will enforce configuration without specifying every option in the configuration files. 'controller_configuration_organizations_enforce_defaults' defaults to the value of 'aap_configuration_enforce_defaults' if it is not explicitly called. This allows for enforced defaults to be toggled for the entire suite of controller configuration roles with a single variable, or for the user to selectively use it. diff --git a/roles/controller_projects/README.md b/roles/controller_projects/README.md index c892dd5a8..a0cbf64d2 100644 --- a/roles/controller_projects/README.md +++ b/roles/controller_projects/README.md @@ -30,9 +30,9 @@ Currently: The following Variables compliment each other. If Both variables are not set, enforcing default values is not done. Enabling these variables enforce default values on options that are optional in the controller API. -This should be enabled to enforce configuration and prevent configuration drift. It is recomended to be enabled, however it is not enforced by default. +This should be enabled to enforce configuration and prevent configuration drift. It is recommended to be enabled, however it is not enforced by default. -Enabling this will enforce configurtion without specifying every option in the configuration files. +Enabling this will enforce configuration without specifying every option in the configuration files. 'controller_configuration_projects_enforce_defaults' defaults to the value of 'aap_configuration_enforce_defaults' if it is not explicitly called. This allows for enforced defaults to be toggled for the entire suite of controller configuration roles with a single variable, or for the user to selectively use it. diff --git a/roles/controller_roles/README.md b/roles/controller_roles/README.md index 9a5bb1c2d..69ae212db 100644 --- a/roles/controller_roles/README.md +++ b/roles/controller_roles/README.md @@ -30,9 +30,9 @@ Currently: The following Variables compliment each other. If Both variables are not set, enforcing default values is not done. Enabling these variables enforce default values on options that are optional in the controller API. -This should be enabled to enforce configuration and prevent configuration drift. It is recomended to be enabled, however it is not enforced by default. +This should be enabled to enforce configuration and prevent configuration drift. It is recommended to be enabled, however it is not enforced by default. -Enabling this will enforce configurtion without specifying every option in the configuration files. +Enabling this will enforce configuration without specifying every option in the configuration files. 'controller_configuration_role_enforce_defaults' defaults to the value of 'aap_configuration_enforce_defaults' if it is not explicitly called. This allows for enforced defaults to be toggled for the entire suite of controller configuration roles with a single variable, or for the user to selectively use it. diff --git a/roles/controller_schedules/README.md b/roles/controller_schedules/README.md index 682090158..c3e691b60 100644 --- a/roles/controller_schedules/README.md +++ b/roles/controller_schedules/README.md @@ -30,9 +30,9 @@ Currently: The following Variables compliment each other. If Both variables are not set, enforcing default values is not done. Enabling these variables enforce default values on options that are optional in the controller API. -This should be enabled to enforce configuration and prevent configuration drift. It is recomended to be enabled, however it is not enforced by default. +This should be enabled to enforce configuration and prevent configuration drift. It is recommended to be enabled, however it is not enforced by default. -Enabling this will enforce configurtion without specifying every option in the configuration files. +Enabling this will enforce configuration without specifying every option in the configuration files. 'controller_configuration_schedules_enforce_defaults' defaults to the value of 'aap_configuration_enforce_defaults' if it is not explicitly called. This allows for enforced defaults to be toggled for the entire suite of controller configuration roles with a single variable, or for the user to selectively use it. diff --git a/roles/controller_teams/README.md b/roles/controller_teams/README.md index e93c7643a..96650cde9 100644 --- a/roles/controller_teams/README.md +++ b/roles/controller_teams/README.md @@ -30,9 +30,9 @@ Currently: The following Variables compliment each other. If Both variables are not set, enforcing default values is not done. Enabling these variables enforce default values on options that are optional in the controller API. -This should be enabled to enforce configuration and prevent configuration drift. It is recomended to be enabled, however it is not enforced by default. +This should be enabled to enforce configuration and prevent configuration drift. It is recommended to be enabled, however it is not enforced by default. -Enabling this will enforce configurtion without specifying every option in the configuration files. +Enabling this will enforce configuration without specifying every option in the configuration files. 'controller_configuration_platform_teams_enforce_defaults' defaults to the value of 'aap_configuration_enforce_defaults' if it is not explicitly called. This allows for enforced defaults to be toggled for the entire suite of controller configuration roles with a single variable, or for the user to selectively use it. diff --git a/roles/controller_users/README.md b/roles/controller_users/README.md index 26eb1fbc2..26344a3dd 100644 --- a/roles/controller_users/README.md +++ b/roles/controller_users/README.md @@ -31,9 +31,9 @@ Currently: The following Variables compliment each other. If Both variables are not set, enforcing default values is not done. Enabling these variables enforce default values on options that are optional in the controller API. -This should be enabled to enforce configuration and prevent configuration drift. It is recomended to be enabled, however it is not enforced by default. +This should be enabled to enforce configuration and prevent configuration drift. It is recommended to be enabled, however it is not enforced by default. -Enabling this will enforce configurtion without specifying every option in the configuration files. +Enabling this will enforce configuration without specifying every option in the configuration files. 'controller_configuration_users_enforce_defaults' defaults to the value of 'aap_configuration_enforce_defaults' if it is not explicitly called. This allows for enforced defaults to be toggled for the entire suite of controller configuration roles with a single variable, or for the user to selectively use it. diff --git a/roles/controller_workflow_job_templates/README.md b/roles/controller_workflow_job_templates/README.md index 04debb1d6..3ddaec9ae 100644 --- a/roles/controller_workflow_job_templates/README.md +++ b/roles/controller_workflow_job_templates/README.md @@ -30,9 +30,9 @@ Currently: The following Variables compliment each other. If Both variables are not set, enforcing default values is not done. Enabling these variables enforce default values on options that are optional in the controller API. -This should be enabled to enforce configuration and prevent configuration drift. It is recomended to be enabled, however it is not enforced by default. +This should be enabled to enforce configuration and prevent configuration drift. It is recommended to be enabled, however it is not enforced by default. -Enabling this will enforce configurtion without specifying every option in the configuration files. +Enabling this will enforce configuration without specifying every option in the configuration files. 'controller_configuration_workflows_enforce_defaults' defaults to the value of 'aap_configuration_enforce_defaults' if it is not explicitly called. This allows for enforced defaults to be toggled for the entire suite of controller configuration roles with a single variable, or for the user to selectively use it. diff --git a/roles/gateway_applications/README.md b/roles/gateway_applications/README.md index 344e0f63f..bea562434 100644 --- a/roles/gateway_applications/README.md +++ b/roles/gateway_applications/README.md @@ -22,9 +22,9 @@ An Ansible Role to create/update/remove Applications on Ansible gateway. The following Variables compliment each other. If Both variables are not set, enforcing default values is not done. Enabling these variables enforce default values on options that are optional in the controller API. -This should be enabled to enforce configuration and prevent configuration drift. It is recomended to be enabled, however it is not enforced by default. +This should be enabled to enforce configuration and prevent configuration drift. It is recommended to be enabled, however it is not enforced by default. -Enabling this will enforce configurtion without specifying every option in the configuration files. +Enabling this will enforce configuration without specifying every option in the configuration files. 'aap_applications_enforce_defaults' defaults to the value of 'aap_configuration_enforce_defaults' if it is not explicitly called. This allows for enforced defaults to be toggled for the entire suite of controller configuration roles with a single variable, or for the user to selectively use it. diff --git a/roles/gateway_service_nodes/README.md b/roles/gateway_service_nodes/README.md index 4c5f3275c..64e6d3b0d 100644 --- a/roles/gateway_service_nodes/README.md +++ b/roles/gateway_service_nodes/README.md @@ -22,9 +22,9 @@ An Ansible Role to configure Service Nodes on Ansible Automation gateway. The following Variables compliment each other. If Both variables are not set, enforcing default values is not done. Enabling these variables enforce default values on options that are optional in the controller API. -This should be enabled to enforce configuration and prevent configuration drift. It is recomended to be enabled, however it is not enforced by default. +This should be enabled to enforce configuration and prevent configuration drift. It is recommended to be enabled, however it is not enforced by default. -Enabling this will enforce configurtion without specifying every option in the configuration files. +Enabling this will enforce configuration without specifying every option in the configuration files. 'gateway_service_nodes_enforce_defaults' defaults to the value of 'aap_configuration_enforce_defaults' if it is not explicitly called. This allows for enforced defaults to be toggled for the entire suite of controller configuration roles with a single variable, or for the user to selectively use it. From 1871e23a7a02b6d045a488a1aefbb28bb5ce3a9b Mon Sep 17 00:00:00 2001 From: Joshua Post Date: Wed, 11 Dec 2024 12:35:51 -0600 Subject: [PATCH 3/5] Correct spelling of Formatting --- roles/controller_credential_types/README.md | 2 +- roles/controller_host_groups/README.md | 2 +- roles/controller_hosts/README.md | 2 +- roles/controller_inventories/README.md | 2 +- roles/controller_inventory_sources/README.md | 2 +- roles/eda_credential_types/README.md | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/roles/controller_credential_types/README.md b/roles/controller_credential_types/README.md index 6e5a0e20e..281ea5981 100644 --- a/roles/controller_credential_types/README.md +++ b/roles/controller_credential_types/README.md @@ -84,7 +84,7 @@ This also speeds up the overall role. |`kind`|"cloud"|no|The type of credential type being added. Note that only cloud and net can be used for creating credential types.| |`state`|`present`|no|Desired state of the resource.| -### Formating Injectors +### Formatting Injectors Injectors use a standard Jinja templating format to describe the resource. diff --git a/roles/controller_host_groups/README.md b/roles/controller_host_groups/README.md index a75ea15e2..332cf41af 100644 --- a/roles/controller_host_groups/README.md +++ b/roles/controller_host_groups/README.md @@ -70,7 +70,7 @@ This also speeds up the overall role. |`controller_configuration_group_loop_delay`|`aap_configuration_loop_delay`|no|This sets the pause between each item in the loop for the role. To help when API is getting overloaded.| |`aap_configuration_async_dir`|`null`|no|Sets the directory to write the results file for async tasks. The default value is set to `null` which uses the Ansible Default of `/root/.ansible_async/`.| -### Formating Variables +### Formatting Variables Variables can use a standard Jinja templating format to describe the resource. diff --git a/roles/controller_hosts/README.md b/roles/controller_hosts/README.md index 8c73cbb95..a1378b946 100644 --- a/roles/controller_hosts/README.md +++ b/roles/controller_hosts/README.md @@ -70,7 +70,7 @@ This also speeds up the overall role. |`controller_configuration_hosts_loop_delay`|`aap_configuration_loop_delay`|no|This sets the pause between each item in the loop for the role. To help when API is getting overloaded.| |`aap_configuration_async_dir`|`null`|no|Sets the directory to write the results file for async tasks. The default value is set to `null` which uses the Ansible Default of `/root/.ansible_async/`.| -### Formating Variables +### Formatting Variables Variables can use a standard Jinja templating format to describe the resource. diff --git a/roles/controller_inventories/README.md b/roles/controller_inventories/README.md index 30f460ca6..78278f474 100644 --- a/roles/controller_inventories/README.md +++ b/roles/controller_inventories/README.md @@ -70,7 +70,7 @@ This also speeds up the overall role. |`controller_configuration_inventories_loop_delay`|`aap_configuration_loop_delay`|no|This sets the pause between each item in the loop for the role. To help when API is getting overloaded.| |`aap_configuration_async_dir`|`null`|no|Sets the directory to write the results file for async tasks. The default value is set to `null` which uses the Ansible Default of `/root/.ansible_async/`.| -### Formating Variables +### Formatting Variables Variables can use a standard Jinja templating format to describe the resource. diff --git a/roles/controller_inventory_sources/README.md b/roles/controller_inventory_sources/README.md index a4baff702..fe84c705a 100644 --- a/roles/controller_inventory_sources/README.md +++ b/roles/controller_inventory_sources/README.md @@ -70,7 +70,7 @@ This also speeds up the overall role. |`controller_configuration_inventory_loop_delay`|`aap_configuration_loop_delay`|no|This sets the pause between each item in the loop for the role. To help when API is getting overloaded.| |`aap_configuration_async_dir`|`null`|no|Sets the directory to write the results file for async tasks. The default value is set to `null` which uses the Ansible Default of `/root/.ansible_async/`.| -### Formating Variables +### Formatting Variables Variables can use a standard Jinja templating format to describe the resource. diff --git a/roles/eda_credential_types/README.md b/roles/eda_credential_types/README.md index 31fefd222..221fb3e1e 100644 --- a/roles/eda_credential_types/README.md +++ b/roles/eda_credential_types/README.md @@ -59,7 +59,7 @@ This also speeds up the overall role. |`injectors`|""|no|dict|Enter injectors using either JSON or YAML syntax. Refer to the Ansible controller documentation for example syntax. See below on proper formatting.| |`state`|`present`|no|str|Desired state of the credential.| -### Formating Injectors +### Formatting Injectors Injectors use a standard Jinja templating format to describe the resource. From e7d45d303d9ac005d2558e4a0f50147dc83a03cd Mon Sep 17 00:00:00 2001 From: Joshua Post Date: Wed, 11 Dec 2024 14:08:08 -0600 Subject: [PATCH 4/5] Various spelling corrections --- docs/CONVERSION_GUIDE.md | 2 +- roles/controller_license/README.md | 4 ++-- roles/controller_organizations/README.md | 2 +- roles/gateway_routes/README.md | 2 +- roles/hub_collection_remote/README.md | 2 +- roles/hub_ee_registry_sync/README.md | 2 +- roles/hub_ee_repository_sync/README.md | 2 +- roles/hub_group_roles/README.md | 6 +++--- roles/hub_namespace/README.md | 2 +- 9 files changed, 12 insertions(+), 12 deletions(-) diff --git a/docs/CONVERSION_GUIDE.md b/docs/CONVERSION_GUIDE.md index 54f87ae4e..da1c1de6b 100644 --- a/docs/CONVERSION_GUIDE.md +++ b/docs/CONVERSION_GUIDE.md @@ -1,4 +1,4 @@ -# Red Hat Communties of Practice Controller Configuration Collection Conversion Guide +# Red Hat Communities of Practice Controller Configuration Collection Conversion Guide ## REQUIREMENTS diff --git a/roles/controller_license/README.md b/roles/controller_license/README.md index 2d4b2ba7a..137d059d6 100644 --- a/roles/controller_license/README.md +++ b/roles/controller_license/README.md @@ -47,7 +47,7 @@ controller_configuration_license_secure_logging defaults to the value of aap_con The module and this role can use either a manifest file, or lookup the subscription on your account. Only one method is needed, provide the appropriate variables to use the either method. -### License Variables for using mainfest +### License Variables for using manifest |Variable Name|Default Value|Required|Type|Description| |:---:|:---:|:---:|:---:|:---:| @@ -68,7 +68,7 @@ The module and this role can use either a manifest file, or lookup the subscript |:---:|:---:|:---:|:---:|:---:| |`filters`|"default values"|no|str|dict of filters to use to narrow the subscription. See example below for how to use this.| |`support_level`|"Self-Support"|no|str|DEPRECATED - changed to `manifest_file` (still works as an alias)| -|`list_num`|0|no|int|List index of the subscription to use, if you want to overide the default, it is recommended to use the filters to limit the pools found.| +|`list_num`|0|no|int|List index of the subscription to use, if you want to override the default, it is recommended to use the filters to limit the pools found.| |`pool_id`|""|no|str|Red Hat or Red Hat Satellite pool_id to attach to.| |`force`|`false`|no|bool|By default, the license will only be applied if controller is currently unlicensed or trial licensed. When force=true, the license is always applied.| |`use_lookup`|`false`|no|bool|Whether or not to lookup subscriptions.| diff --git a/roles/controller_organizations/README.md b/roles/controller_organizations/README.md index 4007c9f0a..a06bcce4c 100644 --- a/roles/controller_organizations/README.md +++ b/roles/controller_organizations/README.md @@ -88,7 +88,7 @@ This role accepts two data models. A simple straightforward easy to maintain mod |`custom_virtualenv`|""|no|str|Local absolute file path containing a custom Python virtualenv to use.| |`max_hosts`|""|no|int|The max hosts allowed in this organization.| |`instance_groups`|""|no|list|list of Instance Groups for this Organization to run on.| -|`galaxy_credentials`|""|no|list|The credentials to use with private automationhub.| +|`galaxy_credentials`|""|no|list|The credentials to use with private automation hub.| |`default_environment`|""|no|str|Default Execution Environment to use for jobs owned by the Organization.| |`notification_templates_started`|""|no|list|The notifications on started to use for this organization in a list.| |`notification_templates_success`|""|no|list|The notifications on success to use for this organization in a list.| diff --git a/roles/gateway_routes/README.md b/roles/gateway_routes/README.md index dbbe394e1..113c31da3 100644 --- a/roles/gateway_routes/README.md +++ b/roles/gateway_routes/README.md @@ -67,7 +67,7 @@ Options for the `routes_list` variable: | `service_path` | N/A | no | str | URL path on the AAP Service cluster to route traffic to | | `service_port` | N/A | no | int | Port on the service cluster to route traffic to | | `tags` | "" | no | str | Comma-separated string, selects which (tagged) nodes receive traffic from this route| -| `state` | `present` | no | str | README.md#state-variable) | +| `state` | `present` | no | str | README.md#state-variable | **Unique value:** diff --git a/roles/hub_collection_remote/README.md b/roles/hub_collection_remote/README.md index 4ae21ad82..5cec9b5d1 100644 --- a/roles/hub_collection_remote/README.md +++ b/roles/hub_collection_remote/README.md @@ -62,7 +62,7 @@ This also speeds up the overall role. |`auth_url`|`https://sso.redhat.com/auth/realms/redhat-external/protocol/openid-connect/token`|no|(`ah_repository_certified`)Remote URL for the repository authentication if separate.|| |`token`|``|no|Token to authenticate to the remote repository.|| |`policy`|`immediate`|no|The policy to use when downloading content. Can be one of `immediate`, `When syncing, download all metadata and content now.`.|| -|`requirements`|``|no|Requirements, a list of collections in [requirements file format](https://docs.ansible.com/ansible/latest/collections_guide/collections_installing.html#install-multiple-collections-with-a-requirements-file) to limit thedownload from remote. This will only download provided collections. This is only the list under collections. See examples for usage.|| +|`requirements`|``|no|Requirements, a list of collections in [requirements file format](https://docs.ansible.com/ansible/latest/collections_guide/collections_installing.html#install-multiple-collections-with-a-requirements-file) to limit the download from remote. This will only download provided collections. This is only the list under collections. See examples for usage.|| |`requirements_file`|``|no|A yaml requirements file to download from remote. In requirements file format. Exclusive with `requirements` || |`username`|``|no|Username to authenticate to the remote repository.|| |`password`|``|no|Password to authenticate to the remote repository.|| diff --git a/roles/hub_ee_registry_sync/README.md b/roles/hub_ee_registry_sync/README.md index eb6a653d9..1dc7de92b 100644 --- a/roles/hub_ee_registry_sync/README.md +++ b/roles/hub_ee_registry_sync/README.md @@ -15,7 +15,7 @@ An Ansible Role to sync EE Registries in Automation Hub. |`aap_request_timeout`|`10`|no|Specify the timeout Ansible should use in requests to the Galaxy or Automation Hub host.|| |`ah_path_prefix`|""|no|API path used to access the api. Either galaxy, automation-hub, or custom|| |`aap_configuration_async_dir`|`null`|no|Sets the directory to write the results file for async tasks. The default value is set to `null` which uses the Ansible Default of `/root/.ansible_async/`.|| -|`hub_ee_registries`|`see below`|yes|Data structure describing your ee_registries, described below. (Note this is the same as for the `ee_registries` role and the variable can be combined. Note that this role will only do anything if the `sync` suboption of this variable is set to true.|| +|`hub_ee_registries`|`see below`|yes|Data structure describing your ee_registries, described below. (Note this is the same as for the `ee_registries` role and the variable can be combined. Note that this role will only do anything if the `sync` sub-option of this variable is set to true.)|| ### Secure Logging Variables diff --git a/roles/hub_ee_repository_sync/README.md b/roles/hub_ee_repository_sync/README.md index c50561062..dead7c7d6 100644 --- a/roles/hub_ee_repository_sync/README.md +++ b/roles/hub_ee_repository_sync/README.md @@ -15,7 +15,7 @@ An Ansible Role to sync EE Repositories in Automation Hub. |`aap_request_timeout`|`10`|no|Specify the timeout Ansible should use in requests to the Galaxy or Automation Hub host.|| |`ah_path_prefix`|""|no|API path used to access the api. Either galaxy, automation-hub, or custom|| |`aap_configuration_async_dir`|`null`|no|Sets the directory to write the results file for async tasks. The default value is set to `null` which uses the Ansible Default of `/root/.ansible_async/`.|| -|`hub_ee_repositories`|`see below`|yes|Data structure describing your ee_repositories, described below. (Note this is the same as for the `ee_repository` role and the variable can be combined. Note that this role will only do anything if the `sync` suboption of this variable is set to true.|| +|`hub_ee_repositories`|`see below`|yes|Data structure describing your ee_repositories, described below. (Note this is the same as for the `ee_repository` role and the variable can be combined. Note that this role will only do anything if the `sync` sub-option of this variable is set to true.)|| ### Secure Logging Variables diff --git a/roles/hub_group_roles/README.md b/roles/hub_group_roles/README.md index be71eade6..d18ae7b9b 100644 --- a/roles/hub_group_roles/README.md +++ b/roles/hub_group_roles/README.md @@ -60,7 +60,7 @@ This also speeds up the overall role. #### role_list The `role_list` variable is a combination of roles and targets that are applied to the groups listed in `groups`. -The structure look slike +The structure looks like ```yaml - roles: @@ -81,7 +81,7 @@ Targets consist of the following. |`collection_remotes`|List of collection remotes to apply the roles to.| |`collection_repositories`|List of collection repositories to apply the roles to.| |`execution_environments`|List of execution environments to apply the roles to.| -|`container_registery_remotes`|List of container registry remotes to apply the roles to.| +|`container_registry_remotes`|List of container registry remotes to apply the roles to.| #### Yaml Example @@ -101,7 +101,7 @@ hub_group_roles: - roles: - galaxy.container_remote targets: - container_registery_remotes: + container_registry_remotes: - quay - roles: - galaxy.user_admin diff --git a/roles/hub_namespace/README.md b/roles/hub_namespace/README.md index 0a93a1184..8fc9854ae 100644 --- a/roles/hub_namespace/README.md +++ b/roles/hub_namespace/README.md @@ -55,7 +55,7 @@ This also speeds up the overall role. |Variable Name|Default Value|Required|Type|Description| |:---:|:---:|:---:|:---:|:---:| |`name`|""|yes|str|Namespace name. Must be lower case containing only alphanumeric characters and underscores.| -|`new_name`|""|yes|str|Setting this option will change the existing name (looked up via the name field.| +|`new_name`|""|yes|str|Setting this option will change the existing name (looked up via the name field.)| |`description`|""|yes|str|Description to use for the Namespace.| |`company`|""|no|str|Namespace owner company name.| |`email`|"password"|yes|str|Namespace contact email.| From 213138404d14d3f74c9e0bc66ade133c3d6e0c21 Mon Sep 17 00:00:00 2001 From: Joshua Post Date: Wed, 11 Dec 2024 15:02:12 -0600 Subject: [PATCH 5/5] Spelling correction for existence --- roles/controller_job_templates/tasks/async.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/controller_job_templates/tasks/async.yml b/roles/controller_job_templates/tasks/async.yml index 41e500f84..bc08a9028 100644 --- a/roles/controller_job_templates/tasks/async.yml +++ b/roles/controller_job_templates/tasks/async.yml @@ -10,7 +10,7 @@ delay: "{{ controller_configuration_job_templates_async_delay }}" rescue: - - name: async | Removing variables existance from result_file + - name: async | Removing variables existence from result_file ansible.builtin.replace: path: "{{ __job_templates_job_async_result.results_file }}" regexp: \{\{.*?\}\}