-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more benchmark apps #7
Comments
Another potential source: the JS framework benchmarks repo at https://github.com/krausest/js-framework-benchmark . |
@markerikson i can start implementing https://github.com/mweststrate/redux-todomvc and refer your stockticker benchmark example |
@Avi98: sure, go ahead, thanks! |
Hi @markerikson, i need your help in providing some direction for setting up "react-redux-benchmarks" . I followed steps provided in the README.md. but while running this command " npm run initialize" i'm getting the following error. please help me. Thank you |
Hmm. Not exactly sure what's going on there. Looks like NPM was having trouble copying a file during the install process. Does this happen every time? |
Yes, steps i followed for setting up the project after cloning it from github |
Hm, it doesn't seem to work as expected. Sorry. |
It works now.
I'll file a new issue about the broken file. |
hi @dai-shi, I don't remember but I think I removed all lock file and reinstalled then it started working. |
@Avi98 Is it that easy? I'll try it later. Anyway, since I already posted a bunch of unrelated comments and you have no problem now, |
More relevant examples we can draw from: https://medium.com/@ryansolid/react-hooks-the-most-performant-way-to-write-react-393e135e1cc |
We can start adding more benchmark apps now.
Pasting some other benchmark-ish repos that are worth investigating and potentially porting:
https://github.com/mweststrate/redux-todomvc
https://github.com/jscriptcoder/stressing-redux
https://github.com/somebody32/high-performance-redux/tree/gh-pages/assets
https://github.com/coderitual/redux-performance
reduxjs/react-redux#686 (comment)
https://github.com/Kalkut/redux-data-frequency-benchmark
Also, we should look at writing some more "real-world" benchmarks, not just FPS stress tests, but that may depend on figuring out what other metrics we want to measure (#3 ).
The text was updated successfully, but these errors were encountered: