Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few minor but important issues #250

Closed
adriatic opened this issue Jun 14, 2022 · 1 comment
Closed

A few minor but important issues #250

adriatic opened this issue Jun 14, 2022 · 1 comment

Comments

@adriatic
Copy link

adriatic commented Jun 14, 2022

Catch all instances of lint warnings in the code / README.md - these include declaring that we use the proper version of Javascript ES8 - in the example below, declaring that we do not want the semicolons, etc

image

Probably this remark is more relevant to create-redwood-app. I suggest that we do that at the level of this application as updating create-redwood-app may take some time.

@jtoar
Copy link
Contributor

jtoar commented Jun 29, 2022

That's odd; I don't see any warnings in my editor. Have you changed the linting configuration locally at all?

image

Do you mind cluing me into what the warning says so that I can try to understand it? Right now I have no idea why there'd be squiggles.

We've been consistently running lint in CI so I feel like this would've come up before. In fact it's catching errors in #257 at the moment: https://github.com/redwoodjs/example-store-stripe/runs/7111786455?check_suite_focus=true#step:3:632.

@jtoar jtoar closed this as not planned Won't fix, can't repro, duplicate, stale Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants