Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross-platform support #8

Open
mauricioaniche opened this issue Feb 14, 2020 · 7 comments
Open

Cross-platform support #8

mauricioaniche opened this issue Feb 14, 2020 · 7 comments
Assignees
@jan-gerling

Comments

@mauricioaniche
Copy link
Contributor

The tool is not working in Windows. Probable cause is how we deal with path names (the awesome / vs \ difference).
@mauricioaniche mauricioaniche changed the title Closs-platform support Cross-platform support Feb 14, 2020
@jan-gerling jan-gerling self-assigned this Feb 18, 2020
@jan-gerling
Copy link
Contributor

I am working on this issue, in order to reduce number of failing tests.

jan-gerling referenced this issue in refactoring-ai/predicting-refactoring-ml Feb 18, 2020
@jan-gerling
Fix cross-platform support - #45
b8f46ad 
 * Added enforce unix stye paths to FilePathUtils
 * Enfoce unix style paths in RefactoringAnalyzer, Yes and
 ProcessMetricscollector
jan-gerling referenced this issue in refactoring-ai/predicting-refactoring-ml Feb 18, 2020
@jan-gerling
Fix cross-platform support - #45
6ae6bc9 
 * Added enforce unix stye paths to FilePathUtils
 * Enfoce unix style paths in RefactoringAnalyzer, Yes,
 ProcessMetricscollector, No and App
 * Enforce unix style paths in FilePathUtils.lastSlashDir
@jan-gerling
Copy link
Contributor

jan-gerling commented Feb 18, 2020 •
edited
Loading

After the PR refactoring-ai/predicting-refactoring-ml#56:

Problem 1:

image

I am exploring this branch on fix/ProjectSizeComputation .
The counting if the test file lines is failing, but the number of test files is counted correctly.
image

I have no idea why the counting in the Counter.java is incorrect, any ideas?
https://github.com/mauricioaniche/predicting-refactoring-ml/blob/dc95738147503ed7ea98f9ca3edfd8bc78029a20/data-collection/src/main/java/refactoringml/util/Counter.java#L20

Problem 2:

image
image

This problem and the ones with the toy repos are solved by refactoring-ai/predicting-refactoring-ml#53.

jan-gerling referenced this issue in refactoring-ai/predicting-refactoring-ml Feb 18, 2020
@jan-gerling
Merge pull request #56 from mauricioaniche/fix/Crossplatform
5a1b17b 
Fix cross-platform support - #45
@jan-gerling
Copy link
Contributor

jan-gerling commented Feb 18, 2020 •
edited
Loading

This issue needs further investigation.

Are all cross-platform issues resolved?

@jan-gerling jan-gerling reopened this Feb 18, 2020
jan-gerling referenced this issue in refactoring-ai/predicting-refactoring-ml Feb 18, 2020
@jan-gerling
Fix Java Test Counting Bug - #45
240eda1
jan-gerling referenced this issue in refactoring-ai/predicting-refactoring-ml Feb 18, 2020
@jan-gerling
Fix Java Test Counting Bug - #45
825c9e1
jan-gerling referenced this issue in refactoring-ai/predicting-refactoring-ml Feb 18, 2020
@jan-gerling
Fix Java Test Counting Bug - #45
fcc6a4f
@jan-gerling
Copy link
Contributor

The counting bug is back:

[ERROR] Tests run: 12, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 132.852 s <<< FAILURE! - in integration.realprojects.ApacheCommonsCSVIntegrationTest
[ERROR] integration.realprojects.ApacheCommonsCSVIntegrationTest.projectMetrics  Time elapsed: 0.003 s  <<< FAILURE!
java.lang.AssertionError: expected:<5140> but was:<5151>
	at integration.realprojects.ApacheCommonsCSVIntegrationTest.projectMetrics(ApacheCommonsCSVIntegrationTest.java:153)

@jan-gerling jan-gerling reopened this Mar 19, 2020
@mauricioaniche
Copy link
Contributor Author

I'd say let's just remove this assertion. Then, maybe we can write a simpler and more controlled test for the line counter.

@jan-gerling
Copy link
Contributor

I'd say let's just remove this assertion. Then, maybe we can write a simpler and more controlled test for the line counter.

Sounds good.

@mauricioaniche
Copy link
Contributor Author

@jan-gerling shall we close this one?

@jan-gerling jan-gerling transferred this issue from refactoring-ai/predicting-refactoring-ml Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jan-gerling jan-gerling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mauricioaniche @jan-gerling