-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub source with versions named differently than conda #145
Comments
One approach for this could be to include it in the bot scripts in each feedstock (xref: #93), the idea being that the script would customize the regex replacement and modifications of the recipe during the PR step. |
Another approach is to replace the current version with the new version in the original text and then run through the Jinja parser to get the new source url. |
@isuruf I think this is what we currently do: https://github.com/regro/cf-scripts/blob/master/03-auto_tick.xsh#L180 I think @dougalsutherland's point is that if the version formatting conda puts out doesn't match the version formatting that the upstream puts out then the bot will most likely replace the conda version with the upstream version, which may not match our formatting requirements. This most likely requires a) the bot to be aware how to do the translation from upstream to conda version formats for every potential recipe, b) allow users to write code for the bot to execute which performs the translation or c) perform the translation via jinja2 templating magic (there may be more options that I'm missing). Note that we do c) in some R recipes which have the We might also want to put out a standard/some advice as to if the |
Right. Github source would give the |
Now I understand your point @isuruf (sorry it took me a while). During Do we have something which says if a version string is in the needed conda format? |
For example, for conda-forge/staged-recipes#5790 for LAMMPS, which uses tags like
stable_16Mar2018
, but of course we want2018.03.16
for conda. I'd also expect that a lot of repos use e.g. av1.5.3
tag for version1.5.3
.It's easy to write some Jinja to convert in either direction, but it seems that the bot expects the source to return versions in the same format as the
package/version
key. There should be some kind of key to add to themeta.yaml
to instruct the bot how to to convert git version tags to conda version numbers.The text was updated successfully, but these errors were encountered: