Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RawURL ahead of Github #165

Closed
isuruf opened this issue Jun 2, 2018 · 8 comments
Closed

Move RawURL ahead of Github #165

isuruf opened this issue Jun 2, 2018 · 8 comments

Comments

@isuruf
Copy link
Member

isuruf commented Jun 2, 2018

Sometimes the github tags don't really match conda versions and checking using RawURL earlier is better.

@CJ-Wright
Copy link
Member

Do you have an example of this? (I don't doubt you, I'm just curious)

@isuruf
Copy link
Member Author

isuruf commented Jun 2, 2018

I was trying to make https://github.com/conda-forge/tbb-feedstock/blob/master/recipe/meta.yaml bot friendly.
Their github tags are like 2018_U4.

@isuruf
Copy link
Member Author

isuruf commented Jun 2, 2018

Issue is in the script, you are replacing the current conda version with the new github tag, right? This implies that the github tag has to be in the same format as the conda version. (There were a few adjustments made to the github tag in update_upstream_versions.py)

With RawURL, we can just check incrementing the conda version and if that fails try the github tags. We can also advice recipe maintainers to use the conda version in {% set version = "2018.0.3" %} and somehow derive the actual github tag 2018_U3 using jinja. This way we can just increment 2018.0.3 to 2018.0.4 in update_upstream_versions.py with RawURL.

@CJ-Wright
Copy link
Member

Hmm, we had a similar issue with the LAMMPS PR conda-forge/staged-recipes#5790 so we might try to make some consistent policy. I had advocated the other way around, for version to be the version number put out by the upstream developers and then have jinja2 templating to convert it to the proper conda syntax. This way we could properly convert the version over by rendering the meta.yaml. I am open to the other way however.

@isuruf
Copy link
Member Author

isuruf commented Jun 3, 2018

Issue is that we don't know how the github tags should be sorted. For example in tbb, it doesn't find 2018_U4 and finds 2018 as the latest. In LAMMPS, it doesn't find an appropriate version at all.

Therefore I think the best idea is to have version be the conda version and the upstream version should be calculated from it.

@CJ-Wright
Copy link
Member

I'm on board with that.

@isuruf
Copy link
Member Author

isuruf commented Jun 3, 2018

#166

@isuruf
Copy link
Member Author

isuruf commented Jun 6, 2018

Fixed in #166

@isuruf isuruf closed this as completed Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants