-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move RawURL ahead of Github #165
Comments
Do you have an example of this? (I don't doubt you, I'm just curious) |
I was trying to make https://github.com/conda-forge/tbb-feedstock/blob/master/recipe/meta.yaml bot friendly. |
Issue is in the script, you are replacing the current conda version with the new github tag, right? This implies that the github tag has to be in the same format as the conda version. (There were a few adjustments made to the github tag in update_upstream_versions.py) With RawURL, we can just check incrementing the conda version and if that fails try the github tags. We can also advice recipe maintainers to use the conda version in |
Hmm, we had a similar issue with the LAMMPS PR conda-forge/staged-recipes#5790 so we might try to make some consistent policy. I had advocated the other way around, for version to be the version number put out by the upstream developers and then have jinja2 templating to convert it to the proper conda syntax. This way we could properly convert the version over by rendering the |
Issue is that we don't know how the github tags should be sorted. For example in Therefore I think the best idea is to have version be the conda version and the upstream version should be calculated from it. |
I'm on board with that. |
Fixed in #166 |
Sometimes the github tags don't really match conda versions and checking using RawURL earlier is better.
The text was updated successfully, but these errors were encountered: