-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package-lock.json still references old versions of (bumped) local packages #96
Comments
@rwjblue I just upgraded to Again, here's what's happening: Running package-a/package.json "name": "@foo/package-a",
- "version": "1.0.0",
+ "version": "1.0.1",
"dependencies": {
- "@foo/package-b": "^1.0.0",
+ "@foo/package-b": "^1.0.1",
} package-b/package.json "name": "@foo/package-b",
- "version": "1.0.0",
+ "version": "1.0.1", It even bumps the version of the root package in the package-lock.json{
"name": "@foo/package-a",
- "version": "1.0.0",
+ "version": "1.0.1",
"packages": {
"": {
"name": "@foo/package-a",
- "version": "1.0.0",
+ "version": "1.0.1", But what it doesn't bump is the version of the local workspace packages in the package-lock.json: {
"name": "@foo/package-a",
"version": "1.0.1", // <-- Cool
"lockfileVersion": 3,
"packages": {
"": {
"name": "@foo/package-a",
"version": "1.0.1" // <-- Cool
},
"@foo/package-b": {
"version": "1.0.0" // <-- This should be 1.0.1 as well, shouldn't it?
}
}
} Running npm ERR! code E404
npm ERR! 404 Not Found - GET https://npm-registry.dg-i.net/@foo%2fpackage-b - no such package available
npm ERR! 404
npm ERR! 404 '@foo/package-b@^1.0.1' is not in this registry.
npm ERR! 404 Any ideas are greatly appreciated! Thanks! Node version: |
After manually patching the line: - "version": "1.0.0" // <-- This should be 1.0.1 as well, shouldn't it?
+ "version": "1.0.1" in my Also, this seems to be something which has changed in recent months because I've been using release-it successfully for over a year now. |
I don't know whether this is the right place, but I noticed that our
package-lock.json
still references old versions after runningrelease-it
with this plugin. The versions of all local packages are updated, say from0.12.0
to0.12.1
, but thepackage-lock.json
still references version0.12.0
for all local packages. Runningnpm install
immediately after creating a new release results in the following error, because the old version of the local package is of course not available anymore:Deleting and recreating
package-lock.json
fixes the error, but that's not a favorable workaround.In contrast to #85 running
npm install
without removingpackage-lock.json
does not help because it fails with the above error instead of just "fixing" the local package versions.I'm using Node@18.13.0, npm@8.19.4, release-it@15.6.0 and @release-it-plugins/workspaces@3.2.0.
The text was updated successfully, but these errors were encountered: