Dependency Duplicated In Table In Pull Request Description

[rarkins]

Discussed in #26025

^{Originally posted by Kurt-von-Laven November 29, 2023}

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

If you're self-hosting Renovate, select which platform you are using.

None

What is your question?

We are using Forking Renovate. The description of ScribeMD/docker-cache#729 lists Yarn v2+ twice, once with a link to a site that never loads and once without. The table in the commit message body correctly lists @yarnpkg/cli once. I am guessing the duplicate in the PR description stems from the fact that both the npm manager and our regex manager bump Yarn. It makes me wonder if our regex manager may be configured incorrectly in some subtle way. How are rows in the table in the PR description deduplicated?

[rarkins]

Reproduction forked to https://github.com/renovate-reproductions/26073

[RahulGautamSingh]

We do de-deuplicate them here.

renovate/lib/workers/repository/update/pr/body/updates-table.ts

Line 87 in de68769

const uniqueRows = [...new Set(rows)];

The issue in this case is that one row has changelog link whereas the other doesn't. And that is because the prBodyDefintions of regex manager and npm manager are different.

for npm it is:

renovate/lib/modules/manager/npm/index.ts

Lines 26 to 30 in de68769

	prBodyDefinitions: {
	Change:
	"[{{#if displayFrom}}`{{{displayFrom}}}` -> {{else}}{{#if currentValue}}`{{{currentValue}}}` -> {{/if}}{{/if}}{{#if displayTo}}`{{{displayTo}}}`{{else}}`{{{newValue}}}`{{/if}}]({{#if depName}}https://renovatebot.com/diffs/npm/{{replace '/' '%2f' depName}}/{{{currentVersion}}}/{{{newVersion}}}{{/if}})",
	},
	};

whereas for regex it is: (regex doesn't have its own so it uses the default value)

renovate/lib/config/options/index.ts

Line 2472 in de68769

Change: '`{{{displayFrom}}}` -> `{{{displayTo}}}`',

I think we only need to compare a few of the row values to determine if the updates are same or not rather than comparing all the values. IMO comapring depName, depType, oldValue and newValue should be enough.

[renovate-release]

🎉 This issue has been resolved in version 37.161.0 🎉

The release is available on:

• GitHub release
• 37.161.0

Your semantic-release bot 📦🚀