Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review/Cleanup current TODO/FIXMEs in the code #6

Open
acmeplus opened this issue Oct 29, 2023 · 1 comment
Open

Review/Cleanup current TODO/FIXMEs in the code #6

acmeplus opened this issue Oct 29, 2023 · 1 comment

Comments

@acmeplus
Copy link
Contributor

Review all the pending TODOs and FIXMEs. If they are no longer valid, remove, otherwise open a ticket to properly track them as issues.

@alpgarcia
Copy link
Contributor

An initial list to review based on my branch:

git grep -n "TODO"
include/Settings.h:164:        // TODO: need to add the logic to override a core/launcher per rom
include/Settings.h:209:        // TODO: need to add the logic to override a core/launcher per rom
resources/config/x86/.simplemenu/alias_PICO-8.txt:1204:17200=TODO
src/Configuration.cpp:100:    // TODO exceptions  ptree_bad_path, ptree_bad_data, both from ptree_error 
src/Configuration.cpp:105:    // TODO exceptions  ptree_bad_path, ptree_bad_data, both from ptree_error
src/Configuration.cpp:118:    // TODO exceptions  ptree_bad_path, ptree_bad_data, both from ptree_error
src/Configuration.cpp:148:    // TODO Do we really need to convert to int and then again to string?
src/I18n.cpp:48:    // TODO exceptions  ptree_bad_path, ptree_bad_data, both from ptree_error 
src/RenderComponent.cpp:197:        // TODO replace clipWidth the correct width based on theme.ini settings
src/Settings.cpp:31:    // TODO should the observer attach itself instead?
src/Settings.cpp:50:    // TODO should the observer attach itself instead?
src/Settings.cpp:70:    // TODO should the observer attach itself instead?
src/Settings.cpp:505:    // TODO one possible improvement here is not to reload everything but
src/Theme.cpp:40:        // TODO fire an exception?
git grep -n "FIXME"
src/RenderComponent.cpp:179:    // Calculate number of pages FIXME: move that to the constructor
src/RenderComponent.cpp:283:    int settingsFontSize = 32;//FIXME: size needs to be dynamic
src/RenderComponent.cpp:293:    int titleFontSize = 64;//FIXME: size needs to be dynamic
src/RenderComponent.cpp:302:    // FIXME: these values need to be dynamic depending on the resolution
src/RenderComponent.cpp:308:    // Calculate number of pages FIXME: move that to the constructor
src/RenderComponent.cpp:348:        // FIXME: replace with proper string once i18n is implemented
src/RenderComponent.cpp:369:    int settingsFontSize = 32; //FIXME: size needs to be dynamic
src/RenderComponent.cpp:379:    int titleFontSize = 64; //FIXME: size needs to be dynamic
src/RenderComponent.cpp:389:    // FIXME: these values need to be dynamic depending on the resolution
src/RenderComponent.cpp:395:    // Calculate number of pages FIXME: move that to the constructor
src/RenderComponent.cpp:446:    int settingsFontSize = 32; //FIXME: size needs to be dynamic
src/RenderComponent.cpp:456:    int titleFontSize = 64; //FIXME: size needs to be dynamic
src/RenderComponent.cpp:466:    // FIXME: these values need to be dynamic depending on the resolution
src/RenderComponent.cpp:472:    // Calculate number of pages FIXME: move that to the constructor
src/Settings.cpp:299:    // FIXME: add boundaries (e.g. min: 0, max: 100)
src/Settings.cpp:310:    // FIXME: add boundaries (e.g. min: 0, max: 100)
src/Settings.cpp:320:    // FIXME: add boundaries (e.g. min: 0, max: 100)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants