Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

espr::parse fails for input ENTITY\n #55

Closed
termoshtt opened this issue May 5, 2021 · 4 comments
Closed

espr::parse fails for input ENTITY\n #55

termoshtt opened this issue May 5, 2021 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@termoshtt
Copy link
Contributor

No description provided.

@termoshtt termoshtt added the bug Something isn't working label May 5, 2021
@termoshtt termoshtt added this to the 0.1.0 milestone May 5, 2021
@termoshtt termoshtt self-assigned this May 5, 2021
@g-rauhoeft
Copy link
Contributor

g-rauhoeft commented Jun 2, 2021

I'm going to look in to this.

Edit: I believe I've fixed it for ENTITY, but it now gets stuck on TYPE. One step further I guess.

@g-rauhoeft
Copy link
Contributor

I've made progress in fixing TYPE parsing. For me the line expression_is_constant(SELF); failed to parse. The reason for this is because the function_call parser first recognized the built-in express exp function and then tried to parse the remainder, which was ression_is_constant(SELF);, resulting in a syntax error. Fixing this requires the use of the work that I submitted earlier regarding reserved keywords. I'll create a new pull request within the next couple of days containing a fix for this.

@g-rauhoeft
Copy link
Contributor

g-rauhoeft commented Jun 8, 2021

The work I've put in to this is located in https://github.com/g-rauhoeft/ruststep/tree/entity_fix_55.
Entities are parsed fine as far as I can see, but it fails on certain functions. It must be due to more order of operation problems, which I'll sort out. Should I make a pull request for this anyway, or would you like to wait until I've fixed the remaining issues?

Quite a few APs parse fine for me now, including AP203-short.

@termoshtt
Copy link
Contributor Author

Fixed in #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants