Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing fields from CSR images #109

Closed
rajnesh-kanwal opened this issue May 31, 2023 · 4 comments · Fixed by #110
Closed

Missing fields from CSR images #109

rajnesh-kanwal opened this issue May 31, 2023 · 4 comments · Fixed by #110

Comments

@rajnesh-kanwal
Copy link
Contributor

My generated PDF seems to be missing the CSR fields. Any ideas what might be causing this?
It works if I change the image type from png to svg.

--- a/cfi_csrs.adoc
+++ b/cfi_csrs.adoc
@@ -6,7 +6,7 @@ This chapter specifies the CSR state of the Zicfisslp extension.
=== Machine environment configuration registers (menvcfg and menvcfgh)

.Machine environment configuration register (menvcfg) for MXLEN=64
-[wavedrom, , ]
+[wavedrom, ,svg]
....
{reg: [

image

My setup:
Ubuntu 20.04
wavedrom 2.6.8
Asciidoctor 2.0.20
asciidoctor-diagram 2.2.9

@wmat
Copy link

wmat commented May 31, 2023 via email

@ved-rivos
Copy link
Collaborator

Thanks for spotting the issue. Would you like to send me a PR for this?

rajnesh-kanwal added a commit to rajnesh-kanwal/riscv-cfi that referenced this issue Jun 1, 2023
This is a workaround to fix [0] issue. For some reason
wavedrom doesn't output CSR field names or any other diagram
text in png format but works fine for svg format.

Also, updating riscv-cfi.pdf.

[0]: riscv#109

Signed-off-by: Rajnesh Kanwal <rkanwal@rivosinc.com>
@rajnesh-kanwal
Copy link
Contributor Author

Thanks for spotting the issue. Would you like to send me a PR for this?

Done. https://github.com/riscv/riscv-cfi/pulls

@ved-rivos
Copy link
Collaborator

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants