generated from riscv/docs-spec-template
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing fields from CSR images #109
Comments
This is a known bug with wavedrom, in particular with node-svg2img. We had
the same issue with the ISA, see
riscv/riscv-isa-manual#1019
The current work around, as you've already discovered is to set wavedrom
images to svg.
…On Wed, May 31, 2023 at 8:34 AM Rajnesh Kanwal ***@***.***> wrote:
My generated PDF seems to be missing the CSR fields. Any ideas what might
be causing this?
It works if I change the image type from png to svg.
--- a/cfi_csrs.adoc
+++ b/cfi_csrs.adoc
@@ -6,7 +6,7 @@ This chapter specifies the CSR state of the Zicfisslp
extension.
=== Machine environment configuration registers (menvcfg and menvcfgh)
.Machine environment configuration register (menvcfg) for MXLEN=64
-[wavedrom, , ]
+[wavedrom, ,svg]
....
{reg: [
[image: image]
<https://user-images.githubusercontent.com/72204611/242273247-9fdf4595-f80e-4083-95d7-db2338c7b5c3.png>
My setup:
Ubuntu 20.04
wavedrom 2.6.8
Asciidoctor 2.0.20
asciidoctor-diagram 2.2.9
—
Reply to this email directly, view it on GitHub
<#109>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAN6ZFQVICJAPXTTHVTVCLXI43DTANCNFSM6AAAAAAYVMTYFM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Thanks for spotting the issue. Would you like to send me a PR for this? |
rajnesh-kanwal
added a commit
to rajnesh-kanwal/riscv-cfi
that referenced
this issue
Jun 1, 2023
This is a workaround to fix [0] issue. For some reason wavedrom doesn't output CSR field names or any other diagram text in png format but works fine for svg format. Also, updating riscv-cfi.pdf. [0]: riscv#109 Signed-off-by: Rajnesh Kanwal <rkanwal@rivosinc.com>
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
My generated PDF seems to be missing the CSR fields. Any ideas what might be causing this?
It works if I change the image type from png to svg.
My setup:
Ubuntu 20.04
wavedrom 2.6.8
Asciidoctor 2.0.20
asciidoctor-diagram 2.2.9
The text was updated successfully, but these errors were encountered: